Re: [Qemu-devel] [PATCH v4] s390x: remove direct reference to mem_path global from s390x code

[David Hildenbrand <david@redhat.com>]

On 30.01.19 10:41, Cornelia Huck wrote:
> On Wed, 30 Jan 2019 08:55:06 +0100
> Igor Mammedov <imammedo@redhat.com> wrote:
> 
>> I plan to deprecate -mem-path option and replace it with memory-backend,
>> for that it's necessary to get rid of mem_path global variable.
>> Do it for s390x case, replacing it with alternative way to enable
>> 1Mb hugepages capability.
>>
>> Todo that replace qemu_mempath_getpagesize() with qemu_getrampagesize()
>> which also checks for -mem-path provided RAM.
>>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> ---
>> v4:
>>   * fix typos in commit message
>>   * add include "exec/ram_addr.h" to make sure it compiles on ppc host
>> v2:
>>   * s/qemu_mempath_getpagesize/qemu_getrampagesiz/ and drop the rest of changes
>>           David Hildenbrand <david@redhat.com>
> 
> Something odd happened here -- I presume you did not want to drop
> David's R-b?
> 
> [I can re-add while applying, no need to resend.]
> 

Indeed, please add

Reviewed-by: David Hildenbrand <david@redhat.com>

>> ---
>>  target/s390x/kvm.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)


-- 

Thanks,

David / dhildenb