From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE4EC433DF for ; Wed, 17 Jun 2020 17:19:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A91F021556 for ; Wed, 17 Jun 2020 17:19:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P3CVUdhq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A91F021556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlbim-0001h6-V0 for qemu-devel@archiver.kernel.org; Wed, 17 Jun 2020 13:19:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlbhS-0000jt-3m for qemu-devel@nongnu.org; Wed, 17 Jun 2020 13:18:10 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:45541 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jlbhP-0002YD-QD for qemu-devel@nongnu.org; Wed, 17 Jun 2020 13:18:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592414286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=QTxQscwcgkv5Ubqxrh8byG/P0cTpjxLRgVRNrt0FcYM=; b=P3CVUdhqbLqyvx9K/QdU4axf+lLhhhAvchEF8xhzpGsqspyIrVw7XjqXLfLpbfEYv5NWAU lW0+yNZoiuqszFlfbh4Lom2sqMo/7AeMuNjx78f6MMHh6WddMp6+Gxf3Fk31I3mq702vIx C95kJJwPewAnGYsODLkuyPq0foJyiYI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-r3HJ5QeQOumisjnUu809jw-1; Wed, 17 Jun 2020 13:18:02 -0400 X-MC-Unique: r3HJ5QeQOumisjnUu809jw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 54625EC1A0; Wed, 17 Jun 2020 17:18:01 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-5.ams2.redhat.com [10.36.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95B435C1D4; Wed, 17 Jun 2020 17:17:56 +0000 (UTC) Subject: Re: [PATCH 1/1] docs/s390x: fix vfio-ap device_del description To: Christian Borntraeger , Peter Maydell References: <20200617160604.5593-1-borntraeger@de.ibm.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <38f61553-10d9-2d45-0e10-ef30f9607b0f@redhat.com> Date: Wed, 17 Jun 2020 19:17:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200617160604.5593-1-borntraeger@de.ibm.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/17 02:02:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand , Cornelia Huck , qemu-devel , Halil Pasic , qemu-s390x , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 17/06/2020 18.06, Christian Borntraeger wrote: > device_del requires an id and not a sysfsfile. > > Signed-off-by: Christian Borntraeger > --- > docs/system/s390x/vfio-ap.rst | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/docs/system/s390x/vfio-ap.rst b/docs/system/s390x/vfio-ap.rst > index 3cd84179a2df..f441df69edde 100644 > --- a/docs/system/s390x/vfio-ap.rst > +++ b/docs/system/s390x/vfio-ap.rst > @@ -606,10 +606,11 @@ action. > > To hot plug a vfio-ap device, use the QEMU ``device_add`` command:: > > - (qemu) device_add vfio-ap,sysfsdev="$path-to-mdev" > + (qemu) device_add vfio-ap,sysfsdev="$path-to-mdev",id="$id" > > Where the ``$path-to-mdev`` value specifies the absolute path to a mediated > device to which AP resources to be used by the guest have been assigned. > +``$id`` is the name value for the optional id parameter. > > Note that on Linux guests, the AP devices will be created in the > ``/sys/bus/ap/devices`` directory when the AP bus subsequently performs its periodic > @@ -632,10 +633,9 @@ or a prior hot plug action. > > To hot unplug a vfio-ap device, use the QEMU ``device_del`` command:: > > - (qemu) device_del vfio-ap,sysfsdev="$path-to-mdev" > + (qemu) device_del "id" Do you want to use $id instead of id here? > > -Where ``$path-to-mdev`` is the same as the path specified when the vfio-ap > -device was attached to the virtual machine's ap-bus. > +Where ``$id`` is the same id that was specified at device creation. ^--- ... since you use $id here. > On a Linux guest, the AP devices will be removed from the ``/sys/bus/ap/devices`` > directory on the guest when the AP bus subsequently performs its periodic scan, With the 1 $ question fixed: Reviewed-by: Thomas Huth