From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v4 13/13] softmmu/cpus: Free cpu->halt_cond in generic_destroy_vcpu_thread()
Date: Wed, 23 Mar 2022 15:43:36 -0700 [thread overview]
Message-ID: <392247bb-a33f-a4b6-1855-1a479ed381d7@linaro.org> (raw)
In-Reply-To: <20220323171751.78612-14-philippe.mathieu.daude@gmail.com>
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
> From: Mark Kanda<mark.kanda@oracle.com>
>
> vCPU hotunplug related leak reported by Valgrind:
>
> ==102631== 56 bytes in 1 blocks are definitely lost in loss record 5,089 of 8,555
> ==102631== at 0x4C3ADBB: calloc (vg_replace_malloc.c:1117)
> ==102631== by 0x69EE4CD: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.5600.4)
> ==102631== by 0x924452: kvm_start_vcpu_thread (kvm-accel-ops.c:69)
> ==102631== by 0x4505C2: qemu_init_vcpu (cpus.c:643)
> ==102631== by 0x76B4D1: x86_cpu_realizefn (cpu.c:6520)
> ==102631== by 0x9344A7: device_set_realized (qdev.c:531)
> ==102631== by 0x93E329: property_set_bool (object.c:2273)
> ==102631== by 0x93C2F8: object_property_set (object.c:1408)
> ==102631== by 0x940796: object_property_set_qobject (qom-qobject.c:28)
> ==102631== by 0x93C663: object_property_set_bool (object.c:1477)
> ==102631== by 0x933D3B: qdev_realize (qdev.c:333)
> ==102631== by 0x455EC4: qdev_device_add_from_qdict (qdev-monitor.c:713)
>
> Signed-off-by: Mark Kanda<mark.kanda@oracle.com>
> Message-Id:<20220321141409.3112932-4-mark.kanda@oracle.com>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> softmmu/cpus.c | 1 +
> 1 file changed, 1 insertion(+)
Eh. Merge with previous.
r~
prev parent reply other threads:[~2022-03-23 22:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 17:17 [PATCH v4 00/13] accel: Fix vCPU memory leaks Philippe Mathieu-Daudé
2022-03-23 17:17 ` [PATCH v4 01/13] cpu: Free cpu->cpu_ases in cpu_address_space_destroy() Philippe Mathieu-Daudé
2022-03-23 18:56 ` Philippe Mathieu-Daudé
2022-03-23 19:14 ` Mark Kanda
2022-03-23 17:17 ` [PATCH v4 02/13] target/i386/kvm: Free xsave_buf when destroying vCPU Philippe Mathieu-Daudé
2022-03-23 21:15 ` Richard Henderson
2022-03-23 17:17 ` [PATCH v4 03/13] target/i386/hvf: Free resources when vCPU is destroyed Philippe Mathieu-Daudé
2022-03-23 21:19 ` Richard Henderson
2022-03-23 17:17 ` [PATCH v4 04/13] accel/hvf: Remove pointless assertion Philippe Mathieu-Daudé
2022-03-23 17:17 ` [PATCH v4 05/13] accel/tcg: Init TCG cflags in vCPU thread handler Philippe Mathieu-Daudé
2022-03-23 21:29 ` Richard Henderson
2022-06-20 20:04 ` Richard Henderson
2022-03-23 17:17 ` [PATCH v4 06/13] accel/tcg: Reorganize tcg_accel_ops_init() Philippe Mathieu-Daudé
2022-03-23 21:31 ` Richard Henderson
2022-06-20 20:09 ` Richard Henderson
2022-03-23 17:17 ` [PATCH v4 07/13] accel-ops: Introduce create_vcpu_thread_precheck / postcheck handlers Philippe Mathieu-Daudé
2022-03-23 22:26 ` Richard Henderson
2022-03-23 17:17 ` [PATCH v4 08/13] accel/tcg: Extract rr_create_vcpu_thread_precheck() Philippe Mathieu-Daudé
2022-03-23 17:17 ` [PATCH v4 09/13] accel/all: Extract common_vcpu_thread_create() Philippe Mathieu-Daudé
2022-03-23 22:11 ` Richard Henderson
2022-03-23 22:15 ` Richard Henderson
2022-03-23 17:17 ` [PATCH v4 10/13] accel-ops: Introduce common_vcpu_thread_destroy() and .precheck handler Philippe Mathieu-Daudé
2022-03-23 22:31 ` Richard Henderson
2022-03-23 17:17 ` [PATCH v4 11/13] accel/tcg: Add rr_destroy_vcpu_thread_precheck() Philippe Mathieu-Daudé
2022-03-23 22:42 ` Richard Henderson
2022-03-23 17:17 ` [PATCH v4 12/13] softmmu/cpus: Free cpu->thread in generic_destroy_vcpu_thread() Philippe Mathieu-Daudé
2022-03-23 17:30 ` Mark Kanda
2022-03-23 22:42 ` Richard Henderson
2022-03-23 17:17 ` [PATCH v4 13/13] softmmu/cpus: Free cpu->halt_cond " Philippe Mathieu-Daudé
2022-03-23 22:43 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=392247bb-a33f-a4b6-1855-1a479ed381d7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philippe.mathieu.daude@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).