From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45842)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1TBKoV-0005xz-O2
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 03:23:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1TBKoP-0006Xz-Sr
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 03:23:15 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:42206)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1TBKoP-0006Xt-Ja
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 03:23:09 -0400
Date: Tue, 11 Sep 2012 03:23:08 -0400 (EDT)
From: Alon Levy <alevy@redhat.com>
Message-ID: <392485929.32838265.1347348188514.JavaMail.root@redhat.com>
In-Reply-To: <9f87efc0d873f96a16b7385a0d36ebb7953eeed3.1347271865.git.uril@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qxl: better cleanup for surface destroy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Uri Lublin <uril@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

> Add back a call to qxl_spice_destroy_surface_wait_complete() in
> qxl_spice_destroy_surface_wait(),
> that was removed by commit c480bb7da465186b84d8427e068ef7502e47ffbf
> 
> It is needed to complete surface-removal cleanup, for non async.
> For async, qxl_spice_destroy_surface_wait_complete is called upon
> operation completion.

Looks good. Cc'ing Gerd.

> 
> Signed-off-by: Uri Lublin <uril@redhat.com>
> ---
>  hw/qxl.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/qxl.c b/hw/qxl.c
> index c2dd3b4..43a2bdf 100644
> --- a/hw/qxl.c
> +++ b/hw/qxl.c
> @@ -196,6 +196,7 @@ static void
> qxl_spice_destroy_surface_wait(PCIQXLDevice *qxl, uint32_t id,
>          spice_qxl_destroy_surface_async(&qxl->ssd.qxl, id,
>          (uintptr_t)cookie);
>      } else {
>          qxl->ssd.worker->destroy_surface_wait(qxl->ssd.worker, id);
> +        qxl_spice_destroy_surface_wait_complete(qxl, id);
>      }
>  }
>  
> --
> 1.7.1
> 
> 
>