* [Qemu-devel] [PATCH] qxl: better cleanup for surface destroy
@ 2012-09-11 7:09 Uri Lublin
2012-09-11 7:23 ` Alon Levy
0 siblings, 1 reply; 2+ messages in thread
From: Uri Lublin @ 2012-09-11 7:09 UTC (permalink / raw)
To: qemu-devel; +Cc: Alon Levy
Add back a call to qxl_spice_destroy_surface_wait_complete() in qxl_spice_destroy_surface_wait(),
that was removed by commit c480bb7da465186b84d8427e068ef7502e47ffbf
It is needed to complete surface-removal cleanup, for non async.
For async, qxl_spice_destroy_surface_wait_complete is called upon operation completion.
Signed-off-by: Uri Lublin <uril@redhat.com>
---
hw/qxl.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index c2dd3b4..43a2bdf 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -196,6 +196,7 @@ static void qxl_spice_destroy_surface_wait(PCIQXLDevice *qxl, uint32_t id,
spice_qxl_destroy_surface_async(&qxl->ssd.qxl, id, (uintptr_t)cookie);
} else {
qxl->ssd.worker->destroy_surface_wait(qxl->ssd.worker, id);
+ qxl_spice_destroy_surface_wait_complete(qxl, id);
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] qxl: better cleanup for surface destroy
2012-09-11 7:09 [Qemu-devel] [PATCH] qxl: better cleanup for surface destroy Uri Lublin
@ 2012-09-11 7:23 ` Alon Levy
0 siblings, 0 replies; 2+ messages in thread
From: Alon Levy @ 2012-09-11 7:23 UTC (permalink / raw)
To: Uri Lublin; +Cc: qemu-devel, Gerd Hoffmann
> Add back a call to qxl_spice_destroy_surface_wait_complete() in
> qxl_spice_destroy_surface_wait(),
> that was removed by commit c480bb7da465186b84d8427e068ef7502e47ffbf
>
> It is needed to complete surface-removal cleanup, for non async.
> For async, qxl_spice_destroy_surface_wait_complete is called upon
> operation completion.
Looks good. Cc'ing Gerd.
>
> Signed-off-by: Uri Lublin <uril@redhat.com>
> ---
> hw/qxl.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/qxl.c b/hw/qxl.c
> index c2dd3b4..43a2bdf 100644
> --- a/hw/qxl.c
> +++ b/hw/qxl.c
> @@ -196,6 +196,7 @@ static void
> qxl_spice_destroy_surface_wait(PCIQXLDevice *qxl, uint32_t id,
> spice_qxl_destroy_surface_async(&qxl->ssd.qxl, id,
> (uintptr_t)cookie);
> } else {
> qxl->ssd.worker->destroy_surface_wait(qxl->ssd.worker, id);
> + qxl_spice_destroy_surface_wait_complete(qxl, id);
> }
> }
>
> --
> 1.7.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-11 7:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-11 7:09 [Qemu-devel] [PATCH] qxl: better cleanup for surface destroy Uri Lublin
2012-09-11 7:23 ` Alon Levy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).