From: Eric Blake <eblake@redhat.com>
To: Roman Kapl <rka@sysgo.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] ppc: Prevent inifnite loop in decrementer auto-reload.
Date: Mon, 9 Jan 2017 08:23:47 -0600 [thread overview]
Message-ID: <39273aca-010e-b23f-9ee2-c7adf0582ec6@redhat.com> (raw)
In-Reply-To: <20170109130749.9795-1-rka@sysgo.com>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On 01/09/2017 07:07 AM, Roman Kapl wrote:
s/inifnite/infinite/ in the subject
> If the DECAR register is set to 0, QEMU tries to reload the decrementer with
> zero in an inifinite loop. According to PPC documentation, the decrementer is
s/inifinite/infinite/
> triggered on 1->0 transition, so avoid reloading the decrementer if if is
> already zero.
>
> The problem does not manifest under Linux, but it is valid to set DECAR to zero
> (and may make sense as part of decrementer initialization when interrupts are
> disabled).
When sending a v2, it's best to do it as a new top-level thread rather
than in-reply-to v1, as some patch tools overlook deeply nested replies.
More hints on sending patches:
http://wiki.qemu.org/Contribute/SubmitAPatch
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-01-09 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 11:23 [Qemu-devel] [PATCH] ppc: Prevent inifnite loop in decrementer auto-reload Roman Kapl
2017-01-09 11:26 ` no-reply
2017-01-09 13:07 ` [Qemu-devel] [PATCH v2] " Roman Kapl
2017-01-09 14:23 ` Eric Blake [this message]
2017-01-10 0:28 ` [Qemu-devel] [PATCH] " David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39273aca-010e-b23f-9ee2-c7adf0582ec6@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rka@sysgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).