From: Richard Henderson <richard.henderson@linaro.org>
To: Yuquan Wang <wangyuquan1236@phytium.com.cn>,
rad@semihalf.com, peter.maydell@linaro.org
Cc: quic_llindhol@quicinc.com, marcin.juszkiewicz@linaro.org,
chenbaozi@phytium.com.cn, qemu-arm@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/1] hw/arm/sbsa-ref: add XHCI controller on PCIe
Date: Thu, 1 Jun 2023 07:50:57 -0700 [thread overview]
Message-ID: <392a7a42-bf1d-c9c6-4e11-2ff68036dd10@linaro.org> (raw)
In-Reply-To: <20230601063737.464751-2-wangyuquan1236@phytium.com.cn>
On 5/31/23 23:37, Yuquan Wang wrote:
> The current sbsa-ref cannot use EHCI controller which is only
> able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB.
> Hence, this add an XHCI on PCIe to provide a usb controller with 64-bit
> DMA capablity.
>
> Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
> ---
> hw/arm/sbsa-ref.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index de21200ff9..a33cd80d69 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -668,6 +668,8 @@ static void create_pcie(SBSAMachineState *sms)
>
> pci_create_simple(pci->bus, -1, "bochs-display");
>
> + pci_create_simple(pci->bus, -1, "qemu-xhci");
Better to use TYPE_QEMU_XHCI.
Need to remove the EHCI controler.
r~
prev parent reply other threads:[~2023-06-01 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 6:37 [PATCH v2 0/1] hw/arm/sbsa-ref: add XHCI controller on PCIe Yuquan Wang
2023-06-01 6:37 ` [PATCH v2 1/1] " Yuquan Wang
2023-06-01 14:50 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=392a7a42-bf1d-c9c6-4e11-2ff68036dd10@linaro.org \
--to=richard.henderson@linaro.org \
--cc=chenbaozi@phytium.com.cn \
--cc=marcin.juszkiewicz@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=wangyuquan1236@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).