* [PATCH v2 0/1] hw/arm/sbsa-ref: add XHCI controller on PCIe
@ 2023-06-01 6:37 Yuquan Wang
2023-06-01 6:37 ` [PATCH v2 1/1] " Yuquan Wang
0 siblings, 1 reply; 3+ messages in thread
From: Yuquan Wang @ 2023-06-01 6:37 UTC (permalink / raw)
To: rad, peter.maydell
Cc: quic_llindhol, marcin.juszkiewicz, chenbaozi, qemu-arm,
qemu-devel, Yuquan Wang
Please review the change.
- sbsa-ref: Add an XHCI on PCIe bus to provide an availiable
usb controller.
Yuquan Wang (1):
hw/arm/sbsa-ref: add XHCI controller on PCIe
hw/arm/sbsa-ref.c | 2 ++
1 file changed, 2 insertions(+)
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/1] hw/arm/sbsa-ref: add XHCI controller on PCIe
2023-06-01 6:37 [PATCH v2 0/1] hw/arm/sbsa-ref: add XHCI controller on PCIe Yuquan Wang
@ 2023-06-01 6:37 ` Yuquan Wang
2023-06-01 14:50 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Yuquan Wang @ 2023-06-01 6:37 UTC (permalink / raw)
To: rad, peter.maydell
Cc: quic_llindhol, marcin.juszkiewicz, chenbaozi, qemu-arm,
qemu-devel, Yuquan Wang
The current sbsa-ref cannot use EHCI controller which is only
able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB.
Hence, this add an XHCI on PCIe to provide a usb controller with 64-bit
DMA capablity.
Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
---
hw/arm/sbsa-ref.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index de21200ff9..a33cd80d69 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -668,6 +668,8 @@ static void create_pcie(SBSAMachineState *sms)
pci_create_simple(pci->bus, -1, "bochs-display");
+ pci_create_simple(pci->bus, -1, "qemu-xhci");
+
create_smmu(sms, pci->bus);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] hw/arm/sbsa-ref: add XHCI controller on PCIe
2023-06-01 6:37 ` [PATCH v2 1/1] " Yuquan Wang
@ 2023-06-01 14:50 ` Richard Henderson
0 siblings, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2023-06-01 14:50 UTC (permalink / raw)
To: Yuquan Wang, rad, peter.maydell
Cc: quic_llindhol, marcin.juszkiewicz, chenbaozi, qemu-arm,
qemu-devel
On 5/31/23 23:37, Yuquan Wang wrote:
> The current sbsa-ref cannot use EHCI controller which is only
> able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB.
> Hence, this add an XHCI on PCIe to provide a usb controller with 64-bit
> DMA capablity.
>
> Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
> ---
> hw/arm/sbsa-ref.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index de21200ff9..a33cd80d69 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -668,6 +668,8 @@ static void create_pcie(SBSAMachineState *sms)
>
> pci_create_simple(pci->bus, -1, "bochs-display");
>
> + pci_create_simple(pci->bus, -1, "qemu-xhci");
Better to use TYPE_QEMU_XHCI.
Need to remove the EHCI controler.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-01 14:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-01 6:37 [PATCH v2 0/1] hw/arm/sbsa-ref: add XHCI controller on PCIe Yuquan Wang
2023-06-01 6:37 ` [PATCH v2 1/1] " Yuquan Wang
2023-06-01 14:50 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).