From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel Berrange" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v2 2/2] ui/clipboard: Don't use g_autoptr just to free a variable
Date: Wed, 8 Dec 2021 09:40:07 +0100 [thread overview]
Message-ID: <393f9756-6b7d-8da4-67c4-d45c4ac3f2bd@redhat.com> (raw)
In-Reply-To: <20211207204038.664133-3-jsnow@redhat.com>
On 12/7/21 21:40, John Snow wrote:
> Clang doesn't recognize that the variable is being "used" and will emit
> a warning:
>
> ../ui/clipboard.c:47:34: error: variable 'old' set but not used [-Werror,-Wunused-but-set-variable]
> g_autoptr(QemuClipboardInfo) old = NULL;
> ^
> 1 error generated.
>
> OK, fine. Just do things the old way.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> ui/clipboard.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-12-08 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 20:40 [PATCH v2 0/2] Misc: build fixes for Fedora 35, Ubuntu et al John Snow
2021-12-07 20:40 ` [PATCH v2 1/2] spice: Update QXLInterface for spice >= 0.15.0 John Snow
2021-12-08 9:11 ` Daniel P. Berrangé
2021-12-15 10:23 ` Philippe Mathieu-Daudé
2021-12-07 20:40 ` [PATCH v2 2/2] ui/clipboard: Don't use g_autoptr just to free a variable John Snow
2021-12-08 8:40 ` Philippe Mathieu-Daudé [this message]
2021-12-08 9:11 ` Daniel P. Berrangé
2021-12-08 13:49 ` Philippe Mathieu-Daudé
2021-12-08 15:22 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=393f9756-6b7d-8da4-67c4-d45c4ac3f2bd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).