From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Greg Kurz" <groug@kaod.org>, "Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH-for-5.2 v3 1/4] s390x: fix build for --without-default-devices
Date: Thu, 5 Nov 2020 12:58:01 +0100 [thread overview]
Message-ID: <394ea3ee-fdef-e25b-4419-3b1bf51a48cc@redhat.com> (raw)
In-Reply-To: <20201104182547.5ae54d3f.cohuck@redhat.com>
Hi Cornelia,
On 11/4/20 6:25 PM, Cornelia Huck wrote:
> On Wed, 4 Nov 2020 12:57:03 +0100
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
>> From: Cornelia Huck <cohuck@redhat.com>
>>
>> s390-pci-vfio.c calls into the vfio code, so we need it to be
>> built conditionally on vfio (which implies CONFIG_LINUX).
>>
>> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Fixes: cd7498d07fbb ("s390x/pci: Add routine to get the vfio dma available count")
>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>> Message-Id: <20201103123237.718242-1-cohuck@redhat.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Acked-by: Greg Kurz <groug@kaod.org>
>> Tested-by: Greg Kurz <groug@kaod.org>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> include/hw/s390x/s390-pci-vfio.h | 3 ++-
>> hw/s390x/meson.build | 2 +-
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> I think you're missing Matt's r-b?
>
> Do you plan to send this, or should I include it on my s390-fixes
> branch?
I plan to send a pull request with gitlab patches (or maybe
they will go via Alex's testing tree) but not soon. If you
are preparing s390-fixes patches, please go ahead taking this
one (I only included to have the series build succeed).
Thanks!
Phil.
next prev parent reply other threads:[~2020-11-05 11:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 11:57 [PATCH-for-5.2 v3 0/4] ci: Move --without-default-devices job from Travis to GitLab Philippe Mathieu-Daudé
2020-11-04 11:57 ` [PATCH-for-5.2 v3 1/4] s390x: fix build for --without-default-devices Philippe Mathieu-Daudé
2020-11-04 17:25 ` Cornelia Huck
2020-11-05 11:58 ` Philippe Mathieu-Daudé [this message]
2020-11-05 12:01 ` Cornelia Huck
2020-11-05 14:43 ` Cornelia Huck
2020-11-04 11:57 ` [PATCH-for-5.2 v3 2/4] hw/9pfs: Fix Kconfig dependency problem between 9pfs and Xen Philippe Mathieu-Daudé
2020-11-04 12:18 ` Christian Schoenebeck
2020-11-04 17:54 ` Greg Kurz
2020-11-05 12:15 ` Philippe Mathieu-Daudé
2020-11-05 12:23 ` Greg Kurz
2020-11-05 12:28 ` Christian Schoenebeck
2020-11-05 15:06 ` Christian Schoenebeck
2020-11-04 11:57 ` [PATCH-for-5.2 v3 3/4] gitlab-ci: Add a job to cover the --without-default-devices config Philippe Mathieu-Daudé
2020-11-04 12:12 ` Wainer dos Santos Moschetta
2020-11-04 11:57 ` [PATCH-for-5.2 v3 4/4] travis-ci: Remove the --without-default-devices job Philippe Mathieu-Daudé
2020-11-04 12:16 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=394ea3ee-fdef-e25b-4419-3b1bf51a48cc@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=fam@euphon.net \
--cc=groug@kaod.org \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).