From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45631)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZKS9g-0001AS-ER
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:16:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZKS9c-00006D-FL
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:16:24 -0400
Received: from mx6-phx2.redhat.com ([209.132.183.39]:39425)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZKS9c-00005v-8e
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:16:20 -0400
Date: Wed, 29 Jul 2015 10:15:48 -0400 (EDT)
From: Thomas Huth <thuth@redhat.com>
Message-ID: <396149374.399711.1438179348073.JavaMail.zimbra@redhat.com>
In-Reply-To: <1438167116-29270-4-git-send-email-yanghy@cn.fujitsu.com>
References: <1438167116-29270-1-git-send-email-yanghy@cn.fujitsu.com>
	<1438167116-29270-4-git-send-email-yanghy@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/12] netfilter: add netfilter_{add|del}
	commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: zhang zhanghailiang <zhang.zhanghailiang@huawei.com>, jasowang@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, stefanha@redhat.com

On Wednesday, July 29, 2015 12:51:47 PM,
"Yang Hongyang" <yanghy@cn.fujitsu.com> wrote:
> 
> add netfilter_{add|del} commands
> This is mostly the same with netdev_{add|del} commands.
> 
> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
> ---
...
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index d3b7932..5326a82 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1253,6 +1253,36 @@ Remove host network device.
>  ETEXI
>  
>      {
> +        .name       = "netfilter_add",
> +        .args_type  = "netfilter:O",
> +        .params     = "[type],id=str,netdev=str[,prop=value][,...]",

I'm not fully sure about the syntax, but writing "[type]" in square
brackets sounds like this parameter is optional to me. But if
I've got this right, it is not optional, is it? So maybe use
"<type>" instead?

 Thomas