From: Eric Blake <eblake@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "fam@euphon.net" <fam@euphon.net>,
"kwolf@redhat.com" <kwolf@redhat.com>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"armbru@redhat.com" <armbru@redhat.com>,
"berrange@redhat.com" <berrange@redhat.com>,
Denis Lunev <den@virtuozzo.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v13 3/3] qcow2: list of bitmaps new test 242
Date: Wed, 6 Feb 2019 08:33:10 -0600 [thread overview]
Message-ID: <397db752-6a3f-fe86-a0c3-f9ee8d2a7efa@redhat.com> (raw)
In-Reply-To: <c879b17e-11d6-bf58-0151-81f1e973a963@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
On 2/6/19 5:58 AM, Andrey Shinkevich wrote:
>> +
>> +def add_bitmap(bitmap_number, persistent, disabled):
>> + granularity = 2**(13 + bitmap_number)
>
> I wish I wrote:
> granularity = 1 << (13 + bitmap_number)
Sure, that's easy to squash in.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-06 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 10:23 [Qemu-devel] [PATCH v13 0/3] qcow2: Add list of bitmaps to ImageInfoSpecificQCow2 Andrey Shinkevich
2019-02-06 10:23 ` [Qemu-devel] [PATCH v13 1/3] bdrv_query_image_info Error parameter added Andrey Shinkevich
2019-02-06 10:23 ` [Qemu-devel] [PATCH v13 2/3] qcow2: Add list of bitmaps to ImageInfoSpecificQCow2 Andrey Shinkevich
2019-02-06 10:23 ` [Qemu-devel] [PATCH v13 3/3] qcow2: list of bitmaps new test 242 Andrey Shinkevich
2019-02-06 11:58 ` Andrey Shinkevich
2019-02-06 14:33 ` Eric Blake [this message]
2019-02-06 14:28 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=397db752-6a3f-fe86-a0c3-f9ee8d2a7efa@redhat.com \
--to=eblake@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=den@virtuozzo.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).