From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Siddhi Katage <siddhi.katage@oracle.com>, qemu-devel@nongnu.org
Cc: joe.jin@oracle.com, dongli.zhang@oracle.com,
christian.ehrhardt@canonical.com, berrange@redhat.com,
pbonzini@redhat.com
Subject: Re: [PATCH 1/1] modules: load modules from /var/run/qemu/<version> directory firstly
Date: Wed, 25 Jan 2023 01:21:56 +0100 [thread overview]
Message-ID: <3982a6f6-9c36-52c4-f512-f3ad31a59584@linaro.org> (raw)
In-Reply-To: <1674585590-13888-1-git-send-email-siddhi.katage@oracle.com>
On 24/1/23 19:39, Siddhi Katage wrote:
> From: Siddhi Katage <siddhi.katage@oracle.com>
>
> An old running QEMU will try to load modules with new build-id first, this
> will fail as expected, then QEMU will fallback to load the old modules that
You corrected the comma/space typo :)
> matches its build-id from /var/run/qemu/<version> directory.
> Make /var/run/qemu/<version> directory as first search path to load modules.
>
> Fixes: bd83c861c0 ("modules: load modules from versioned /var/run dir")
> Signed-off-by: Siddhi Katage <siddhi.katage@oracle.com>
> ---
> util/module.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-01-25 0:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 18:39 [PATCH 1/1] modules: load modules from /var/run/qemu/<version> directory firstly Siddhi Katage
2023-01-25 0:21 ` Philippe Mathieu-Daudé [this message]
2023-02-28 5:18 ` [External] : " Siddhi Katage
-- strict thread matches above, loose matches on Subject: below --
2023-01-23 18:48 Siddhi Katage
2023-01-24 7:55 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3982a6f6-9c36-52c4-f512-f3ad31a59584@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dongli.zhang@oracle.com \
--cc=joe.jin@oracle.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=siddhi.katage@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).