From: Lukas Straub <lukasstraub2@web.de>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Alberto Garcia" <berto@igalia.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Zhang Chen" <chen.zhang@intel.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v3 3/7] boot_linux.py: Use pick_qemu_util
Date: Tue, 4 Aug 2020 12:46:52 +0200 [thread overview]
Message-ID: <39a4ee6737c33d28d6b396d17b466ef56ba811fd.1596536719.git.lukasstraub2@web.de> (raw)
In-Reply-To: <cover.1596536719.git.lukasstraub2@web.de>
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
Replace duplicate code with pick_qemu_util.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
tests/acceptance/boot_linux.py | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py
index 0055dc7cee..0d3629cabb 100644
--- a/tests/acceptance/boot_linux.py
+++ b/tests/acceptance/boot_linux.py
@@ -31,15 +31,8 @@ class BootLinuxBase(Test):
def download_boot(self):
self.log.debug('Looking for and selecting a qemu-img binary to be '
'used to create the bootable snapshot image')
- # If qemu-img has been built, use it, otherwise the system wide one
- # will be used. If none is available, the test will cancel.
- qemu_img = os.path.join(BUILD_DIR, 'qemu-img')
- if not os.path.exists(qemu_img):
- qemu_img = find_command('qemu-img', False)
- if qemu_img is False:
- self.cancel('Could not find "qemu-img", which is required to '
- 'create the bootable image')
- vmimage.QEMU_IMG = qemu_img
+
+ vmimage.QEMU_IMG = self.pick_qemu_util("qemu-img")
self.log.info('Downloading/preparing boot image')
# Fedora 31 only provides ppc64le images
--
2.20.1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-04 10:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 10:46 [PATCH v3 0/7] colo: Introduce resource agent and test suite/CI Lukas Straub
2020-08-04 10:46 ` [PATCH v3 1/7] block/quorum.c: stable children names Lukas Straub
2020-09-02 12:22 ` Max Reitz
2020-08-04 10:46 ` [PATCH v3 2/7] avocado_qemu: Introduce pick_qemu_util to pick qemu utility binaries Lukas Straub
2020-08-04 10:46 ` Lukas Straub [this message]
2020-08-04 10:46 ` [PATCH v3 4/7] colo: Introduce resource agent Lukas Straub
2020-08-04 10:47 ` [PATCH v3 5/7] colo: Introduce high-level test suite Lukas Straub
2020-08-04 10:47 ` [PATCH v3 6/7] configure,Makefile: Install colo resource-agent Lukas Straub
2020-09-04 10:45 ` Philippe Mathieu-Daudé
2020-08-04 10:47 ` [PATCH v3 7/7] MAINTAINERS: Add myself as maintainer for COLO resource agent Lukas Straub
2020-08-18 12:27 ` [PATCH v3 0/7] colo: Introduce resource agent and test suite/CI Lukas Straub
2020-08-18 12:31 ` Philippe Mathieu-Daudé
2020-08-27 8:40 ` Lukas Straub
2020-09-04 10:42 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a4ee6737c33d28d6b396d17b466ef56ba811fd.1596536719.git.lukasstraub2@web.de \
--to=lukasstraub2@web.de \
--cc=berto@igalia.com \
--cc=chen.zhang@intel.com \
--cc=crosa@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).