From: "Michal Prívozník" <mprivozn@redhat.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] accel/kvm: Make "kernel_irqchip" default on
Date: Mon, 30 Dec 2019 13:01:23 +0100 [thread overview]
Message-ID: <39a6be44-fd9a-60cd-6268-5dcd8f460bb4@redhat.com> (raw)
In-Reply-To: <20191228104326.21732-1-xiaoyao.li@intel.com>
On 12/28/19 11:43 AM, Xiaoyao Li wrote:
> Commit 11bc4a13d1f4 ("kvm: convert "-machine kernel_irqchip" to an
> accelerator property") moves kernel_irqchip property from "-machine" to
> "-accel kvm", but it forgets to set the default value of
> kernel_irqchip_allowed and kernel_irqchip_split.
>
> Also cleaning up the three useless members (kernel_irqchip_allowed,
> kernel_irqchip_required, kernel_irqchip_split) in struct MachineState.
>
> Fixes: 11bc4a13d1f4 ("kvm: convert "-machine kernel_irqchip" to an accelerator property")
> Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> Changes in v2:
> - Add Reported-by tag;
> - Initialize kernel_irqchip_split in init_machine();
> ---
> accel/kvm/kvm-all.c | 3 +++
> include/hw/boards.h | 3 ---
> 2 files changed, 3 insertions(+), 3 deletions(-)
Huh, I've just converged to the same patch.
Tested-by: Michal Prívozník <mprivozn@redhat.com>
Michal
next prev parent reply other threads:[~2019-12-30 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 10:43 [PATCH v2] accel/kvm: Make "kernel_irqchip" default on Xiaoyao Li
2019-12-30 12:01 ` Michal Prívozník [this message]
2020-01-07 10:32 ` Paolo Bonzini
2020-01-08 10:17 ` Cornelia Huck
2020-01-08 11:38 ` Xiaoyao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a6be44-fd9a-60cd-6268-5dcd8f460bb4@redhat.com \
--to=mprivozn@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vkuznets@redhat.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).