From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 701BCC4708E for ; Sun, 5 Nov 2023 14:43:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzeKe-0005rW-HD; Sun, 05 Nov 2023 09:42:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzeKc-0005r4-49 for qemu-devel@nongnu.org; Sun, 05 Nov 2023 09:42:30 -0500 Received: from mout.kundenserver.de ([217.72.192.73]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzeKa-0003Oj-Iq for qemu-devel@nongnu.org; Sun, 05 Nov 2023 09:42:29 -0500 Received: from [192.168.100.1] ([82.142.8.70]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MLR5h-1qhIMl26Xz-00IV4C; Sun, 05 Nov 2023 15:42:24 +0100 Message-ID: <39a86e81-20fe-4e5e-9bdb-d876b3e85252@vivier.eu> Date: Sun, 5 Nov 2023 15:42:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] macfb: don't clear interrupts when writing to DAFB_RESET Content-Language: fr To: Mark Cave-Ayland , qemu-devel@nongnu.org References: <20231026085650.917663-1-mark.cave-ayland@ilande.co.uk> <20231026085650.917663-2-mark.cave-ayland@ilande.co.uk> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+wsF4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +c7BTQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAcLBXwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== In-Reply-To: <20231026085650.917663-2-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:EagZ7hKVSA5oS9j/O6UMmzqG+I2hi7eILFgfm8sDJo6iFvd/CFj XuDlC/Li9GDTHqlCtYSy2/DWshVtaAmzTAubTxVrL5SXO4lMzaRkqtjZO7megid+juvnLQ3 KoYtkiBwvBzL4VH5Uw8nBvtpuwAocPxblegYDasdzdXQ/RBaFO5UwZOIQrWeZjKbR+eN2EK SHQjUPTxB8GqQuoUWqzjg== UI-OutboundReport: notjunk:1;M01:P0:LhC9ygcpbNA=;P5LLfwbsBPjulzJfmqVdVkERWIe Soz8gDWBsnahIRUY3bBe15KaGnneQqiMjGT+Hw2MOaUUTzaJyIIGxcQl13RMniHsq3kpn6kX5 xvEDq+K7YJsrJW00cFqvf41kDO5e7YYecFNAYeLBhqrhGoX4b75AL/aW0BQ8+uSkoVdMM1BhF pe9Tlsnd4Gxu34py/K5JGN91ZamIBenSrrdgBhNuub8lVZRGCFSZkibEJrC5h2kxfJ2KrH3Fn yJdfmNRh1PZrnDEt22naFy6+MI/zS7YuiuiDf81sVA1ZAAsOU2394lxUSMGcsClxSRtgG+hSz IniwAoOxM/mx2RPlQpiXjmlOzTiq5CY5LLGXgvgF9OFFhmWanpW8BWlUWrFg5GAnT29x68siW E5GMVaewwezoEl8D+K9t56Beauy5vboECEceo3kLjMZUggx7ZajVdBEaUkFPNTq5cIhGyB2Qp T08DPIUGdiwCfh5WkJERHrJ9zlYcGAQjJgYt7Cd4sAAx4TRy9O5qck4z9MyMfyT0T9dviQgdS cGP/mVrXIXe+2w5R94Pmas9wjwSMsKhOnrrFEOTy2PReJXslkfpprMOkS1KSN6hWhoarz+dVT fIrO+d52Y9uD5sCVcrvKMMFtHOjHsoy0/v2ERWw0Za+tnFRIXgypf8pMRrNs6Wjvl0kURCDON ij0qIqWopeYlDrzxsp8gUQ5tGyvKa7Qd4voHIMdi+DdPCpmdWDwQqhumiUo77aJGfqgV2U944 4g1DLULGnlPlElOPgwz4Kz9pgWot6FFmSwG+jD5Sc9rJyZpXswry/Qku/9C5pIhMAWstXi7BU xcljX3h8e+iQzFjB6P6F1u5sZumgyYiAVL2IY4ylDQsMG7sZyZ0epkLXiP9xvXyngAY9f4j61 8M3HZO+kGrh1Kjw== Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Le 26/10/2023 à 10:56, Mark Cave-Ayland a écrit : > Traces from A/UX suggest that this register is only used to reset the framebuffer > LUT (colour lookup table) and not any other device state. > > Signed-off-by: Mark Cave-Ayland > --- > hw/display/macfb.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/display/macfb.c b/hw/display/macfb.c > index 2f8e016566..28db2e9f24 100644 > --- a/hw/display/macfb.c > +++ b/hw/display/macfb.c > @@ -585,8 +585,6 @@ static void macfb_ctrl_write(void *opaque, > break; > case DAFB_RESET: > s->palette_current = 0; > - s->regs[DAFB_INTR_STAT >> 2] &= ~DAFB_INTR_VBL; > - macfb_update_irq(s); > break; > case DAFB_LUT: > s->color_palette[s->palette_current] = val; Reviewed-by: Laurent Vivier