From: Hollis Blanchard <hollisb@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: l_indien@magic.fr, aurelien@aurel32.net
Subject: [Qemu-devel] [PATCH 2 of 4] [qemu ppc uic] Remove interrupt polarity code
Date: Wed, 23 Apr 2008 17:23:53 -0500 [thread overview]
Message-ID: <39a9e699b6d6ca826b1a.1208989433@localhost.localdomain> (raw)
In-Reply-To: <patchbomb.1208989431@localhost.localdomain>
Interrupt polarity should have no functional effect, since qemu tracks logical
IRQ state, not the electrical state of physical lines.
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
diff --git a/qemu/hw/ppc4xx_devs.c b/qemu/hw/ppc4xx_devs.c
--- a/qemu/hw/ppc4xx_devs.c
+++ b/qemu/hw/ppc4xx_devs.c
@@ -377,10 +377,7 @@
if (irq_num < 0 || irq_num > 31)
return;
sr = uic->uicsr;
- if (!(uic->uicpr & mask)) {
- /* Negatively asserted IRQ */
- level = level == 0 ? 1 : 0;
- }
+
/* Update status register */
if (uic->uictr & mask) {
/* Edge sensitive interrupt */
@@ -479,7 +476,6 @@
break;
case DCR_UICPR:
uic->uicpr = val;
- ppcuic_trigger_irq(uic);
break;
case DCR_UICTR:
uic->uictr = val;
next prev parent reply other threads:[~2008-04-23 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 22:23 [Qemu-devel] [PATCH 0 of 4] PowerPC 4xx device emulation improvements Hollis Blanchard
2008-04-23 22:23 ` [Qemu-devel] [PATCH 1 of 4] [qemu ppc uic] Order IRQ bit numbers as described in the UIC documentation Hollis Blanchard
2008-04-23 22:23 ` Hollis Blanchard [this message]
2008-04-23 22:23 ` [Qemu-devel] [PATCH 3 of 4] [qemu ppc uic] Remember the state of level-triggered interrupts Hollis Blanchard
2008-04-23 22:23 ` [Qemu-devel] [PATCH 4 of 4] [qemu ppc pci] Emulate the PCI(-legacy) controller found on some 440 SoCs Hollis Blanchard
2008-05-05 3:46 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a9e699b6d6ca826b1a.1208989433@localhost.localdomain \
--to=hollisb@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=l_indien@magic.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).