From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Cc: Thomas Huth <thuth@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
qemu-block@nongnu.org, Paul Durrant <paul@xen.org>,
Anthony Perard <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org, John Snow <jsnow@redhat.com>
Subject: Re: [RFC PATCH 1/4] hw/ide/Kconfig: IDE_ISA requires ISA_BUS
Date: Fri, 29 Jan 2021 20:59:54 +0100 [thread overview]
Message-ID: <39ac2417-c4ee-49ca-0bc0-347981ec6fb3@redhat.com> (raw)
In-Reply-To: <20210129194415.3925153-2-f4bug@amsat.org>
On 29/01/21 20:44, Philippe Mathieu-Daudé wrote:
> hw/ide/ioport.c has a strong dependency on hw/isa/isa-bus.c:
>
> /usr/bin/ld: libcommon.fa.p/hw_ide_ioport.c.o: in function `ide_init_ioport':
> /usr/bin/ld: hw/ide/ioport.c:61: undefined reference to `isa_register_portio_list'
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/ide/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig
> index 5d9106b1ac2..41cdd9cbe03 100644
> --- a/hw/ide/Kconfig
> +++ b/hw/ide/Kconfig
> @@ -12,7 +12,7 @@ config IDE_PCI
>
> config IDE_ISA
> bool
> - depends on ISA_BUS
> + select ISA_BUS
> select IDE_QDEV
>
> config IDE_PIIX
This is incorrect. Buses are "depended on", not selected, and this is
documented in docs/devel/kconfig.rst.
Paolo
next prev parent reply other threads:[~2021-01-29 20:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 19:44 [RFC PATCH 0/4] hw/xen: Fixes to only build the XEN_PV machine Philippe Mathieu-Daudé
2021-01-29 19:44 ` [RFC PATCH 1/4] hw/ide/Kconfig: IDE_ISA requires ISA_BUS Philippe Mathieu-Daudé
2021-01-29 19:59 ` Paolo Bonzini [this message]
2021-01-29 19:44 ` [RFC PATCH 2/4] hw/ide/Kconfig: IDE_PIIX requires IDE_ISA Philippe Mathieu-Daudé
2021-01-29 20:00 ` Paolo Bonzini
2021-01-29 19:44 ` [RFC PATCH 3/4] hw/xen/Kconfig: Introduce XEN_PV config Philippe Mathieu-Daudé
2021-01-29 20:01 ` Paolo Bonzini
2021-01-29 19:44 ` [RFC PATCH 4/4] hw/xen: Have the xenpv machine select 9pfs Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39ac2417-c4ee-49ca-0bc0-347981ec6fb3@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=paul@xen.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=thuth@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).