From: Stefan Berger <stefanb@linux.ibm.com>
To: "Darren Kenny" <darren.kenny@oracle.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] tests/qtest/tpm: Declare input buffers const and static
Date: Wed, 2 Sep 2020 10:37:40 -0400 [thread overview]
Message-ID: <39c26bc1-16c5-ba7c-3e39-8d56e807e082@linux.ibm.com> (raw)
In-Reply-To: <m2d034tvws.fsf@oracle.com>
On 9/2/20 4:39 AM, Darren Kenny wrote:
> On Wednesday, 2020-09-02 at 10:09:09 +02, Philippe Mathieu-Daudé wrote:
>> The functions using these arrays expect a "const unsigned char *"
>> argument, it is safe to declare these as 'static const'.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Would this qualify for qemu-trivial?
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
next prev parent reply other threads:[~2020-09-02 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 8:09 [PATCH] tests/qtest/tpm: Declare input buffers const and static Philippe Mathieu-Daudé
2020-09-02 8:39 ` Darren Kenny
2020-09-02 14:37 ` Stefan Berger [this message]
2020-09-02 15:59 ` Thomas Huth
2020-09-02 9:47 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39c26bc1-16c5-ba7c-3e39-8d56e807e082@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=darren.kenny@oracle.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).