From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C02C433DB for ; Wed, 24 Feb 2021 12:27:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BBCC64ED1 for ; Wed, 24 Feb 2021 12:27:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BBCC64ED1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEtGj-0001q1-2h for qemu-devel@archiver.kernel.org; Wed, 24 Feb 2021 07:27:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEtFP-0000qX-P2 for qemu-devel@nongnu.org; Wed, 24 Feb 2021 07:26:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55451) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEtFN-0001Us-Fu for qemu-devel@nongnu.org; Wed, 24 Feb 2021 07:26:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614169588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/CRAkw4jrNYafO8dLBQfMq0SD7HD0L0F3sU0iuCuYWk=; b=NMWDdl0p270Sk1UJp5zhwFMXtB8154sabUL29GcJT0NFgFhuytvsWY/Y59W/clim6hUqlB X4LWQbXepySpXUzcMQ9+vP6tCwXtPxEy8e3P250Bb8Bqb3YkTzkKgLxhxBNnoKlCamOAou 9N/jFosV5MAzx6rMEvWBpJ92nwI2ung= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-539-ugW8_KXiPH6dEkIDwGBDzg-1; Wed, 24 Feb 2021 07:26:27 -0500 X-MC-Unique: ugW8_KXiPH6dEkIDwGBDzg-1 Received: by mail-ed1-f70.google.com with SMTP id u2so763411edj.20 for ; Wed, 24 Feb 2021 04:26:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/CRAkw4jrNYafO8dLBQfMq0SD7HD0L0F3sU0iuCuYWk=; b=KP+LlBk3JRvN7I98tIvLWOOFm7Ihzv9C1mZhQipJvgQIT+j9bQE9mzMZ9I5/Yo3nJv ZLulSYKw8eSOBhm2d8INKgI3jS66jZPOknvgGjhtoj1WO2hX8yBlXMLGF983eU5CpuLR JVhNl/7CHT8K6M9f5cZKrdqxSvlBiZMV2h+fm4Wh5/5Q/8pH7jVHkd2Vr1U5/d4ok51d SurQwcluxDc6+qgR50oT0/iS2aNjtqyOi0KeB4COM/TwuTBjedugxNcVbMwx6IMmb5GW xmsAmkKi+iSAUwjN6vI+YG1d9BDIUGOWnPKyqFaOmV9Vflrhwdag4DY6McR+mg5eSEhB +RIw== X-Gm-Message-State: AOAM531ZA01Z/BCfsSUFDF1w/yv4WvFkeG8qXobari37r+ASn3f8Lg7+ dNPiqPCZNr1i4GfCxh+YDCOSWyBGcC2CBOJyYui2tMY9mQNukIlqx4MdR+8QrWcvkLuy8AwGJt2 sqX/WWoqqXk7ttuM= X-Received: by 2002:a05:6402:1f3:: with SMTP id i19mr32769107edy.217.1614169585866; Wed, 24 Feb 2021 04:26:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJxAa9i3hkxnxuBOX5fNHOfRnFHm9wBdeDreJXAUrlv5luwisp/pS2f+uLe3j3k5ACDftciDzQ== X-Received: by 2002:a05:6402:1f3:: with SMTP id i19mr32769087edy.217.1614169585610; Wed, 24 Feb 2021 04:26:25 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id br22sm1232458ejb.117.2021.02.24.04.26.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Feb 2021 04:26:25 -0800 (PST) Subject: Re: [PATCH] meson: Only generate trace files for selected targets To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210224120923.3154325-1-philmd@redhat.com> From: Paolo Bonzini Message-ID: <39cc99dd-54d5-9dd1-d66a-7947686dbada@redhat.com> Date: Wed, 24 Feb 2021 13:26:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210224120923.3154325-1-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 24/02/21 13:09, Philippe Mathieu-Daudé wrote: > We don't need to generate trace files for targets we > are not building. Restrict the the ones selected. > > Signed-off-by: Philippe Mathieu-Daudé > --- > meson.build | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/meson.build b/meson.build > index 05a67c20d93..c9b0433667d 100644 > --- a/meson.build > +++ b/meson.build > @@ -1826,15 +1826,6 @@ > trace_events_subdirs += [ > 'accel/tcg', > 'hw/core', > - 'target/arm', > - 'target/hppa', > - 'target/i386', > - 'target/i386/kvm', > - 'target/mips', > - 'target/ppc', > - 'target/riscv', > - 'target/s390x', > - 'target/sparc', > ] > endif > > @@ -2166,6 +2157,7 @@ > t = target_arch[arch].apply(config_target, strict: false) > arch_srcs += t.sources() > arch_deps += t.dependencies() > + trace_events_subdirs += ['target' / arch] > > target_common = common_ss.apply(config_target, strict: false) > objects = common_all.extract_objects(target_common.sources()) > Is this still okay if there is no trace-events file for a given arch? Paolo