From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A3BC197BF for ; Mon, 7 Dec 2020 13:42:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4790823436 for ; Mon, 7 Dec 2020 13:42:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4790823436 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmGmU-0006IY-13 for qemu-devel@archiver.kernel.org; Mon, 07 Dec 2020 08:42:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmG1c-0001rw-HM for qemu-devel@nongnu.org; Mon, 07 Dec 2020 07:53:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmG1a-0003GI-A6 for qemu-devel@nongnu.org; Mon, 07 Dec 2020 07:53:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607345633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8jQXhZcYJDxQ+pyrZJ9955D0Y/b7j+Ci1hyg9wiMJqU=; b=B5mNN6ssD+k8xdQceVG3A/oXt1xDCPvwExE0Jo6i1pil8ftFR8M/oq/lmJWRyRInCsV7L7 ICPVXXqSqRbPvi8nbyB5seKrq0wXUGWiU+8xSsm+DMHdHK/IQcv9zI7wHqivS1wnK00oKX lyacLPihPVns0fG0bueqa6bE5hqWXow= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-7-jpqKp0r4MP-A3D8TQCaJuw-1; Mon, 07 Dec 2020 07:53:52 -0500 X-MC-Unique: jpqKp0r4MP-A3D8TQCaJuw-1 Received: by mail-wm1-f70.google.com with SMTP id a134so4106125wmd.8 for ; Mon, 07 Dec 2020 04:53:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8jQXhZcYJDxQ+pyrZJ9955D0Y/b7j+Ci1hyg9wiMJqU=; b=imK9vN8uFuqXvRrc+TRQlnCzlrW+MAx+BdFTjNaN7Hsno3iWZeIdTxennoVqpBv9Y6 qoykjvNiBGlP5vbs+5OYDp80RhgABbUvzRdUlNQFrEcKAFfa0a2tb8mFg92BXtH2oeqm V1C6117c0tfb5zxLs/PHJWgZpr8EYwH1CqP86zrbI7AyqZaelMoLuAxUmBy8yTMaTNnr /AbpPuIvTqI3BHJUZjm64Mge8rIlRpxq4+ABcG87GHDX4v67qkjlpMBIwC2Q1oaoZ00A SvkeNc69Cv85BNBk7CvrHlelIpzvF94vQ9+LlfUMbjYO0FsgcVZQ8f9iEwJuXcrRyVbG LEtA== X-Gm-Message-State: AOAM533J3WnwQRFPhHdtRHH/Zq/7P0XZ3tIhloazrMgz5PA2OnjsPfMz e2oElTB0eM+nQxKzTLEvVrdLca3kDUIMJcIoMronTpObLauK5sOO5OyKQpXix+VYrkFYkrH7keP BqkuTOSnxdFR5Rlg= X-Received: by 2002:adf:e547:: with SMTP id z7mr16664433wrm.283.1607345630921; Mon, 07 Dec 2020 04:53:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJwL3U84FFw+0qFmC+nPsQaUjHyjhjpgeVy6OSntbXqxnSM9myKiFBtd0teG8BcdiMc8S14tKw== X-Received: by 2002:adf:e547:: with SMTP id z7mr16664424wrm.283.1607345630765; Mon, 07 Dec 2020 04:53:50 -0800 (PST) Received: from [192.168.1.36] (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id h15sm15059392wrw.15.2020.12.07.04.53.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Dec 2020 04:53:50 -0800 (PST) Subject: Re: [PATCH v2 3/5] gitlab-ci: Introduce 'cross_accel_build_job' template To: Thomas Huth , qemu-devel@nongnu.org References: <20201207112353.3814480-1-philmd@redhat.com> <20201207112353.3814480-4-philmd@redhat.com> <93d186c0-feea-8e47-2a03-5276fb898bff@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <39d13e9c-1fb4-2fa9-6cf4-01086ad920aa@redhat.com> Date: Mon, 7 Dec 2020 13:53:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <93d186c0-feea-8e47-2a03-5276fb898bff@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcelo Tosatti , kvm@vger.kernel.org, Paul Durrant , Cornelia Huck , Wainer dos Santos Moschetta , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Stefano Stabellini , Claudio Fontana , Willian Rampazzo , Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/7/20 12:37 PM, Thomas Huth wrote: > On 07/12/2020 12.23, Philippe Mathieu-Daudé wrote: >> Introduce a job template to cross-build accelerator specific >> jobs (enable a specific accelerator, disabling the others). >> >> The specific accelerator is selected by the $ACCEL environment >> variable (default to KVM). >> >> Extra options such disabling other accelerators are passed >> via the $ACCEL_CONFIGURE_OPTS environment variable. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> .gitlab-ci.d/crossbuilds.yml | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml >> index 099949aaef3..d8685ade376 100644 >> --- a/.gitlab-ci.d/crossbuilds.yml >> +++ b/.gitlab-ci.d/crossbuilds.yml >> @@ -13,6 +13,23 @@ >> xtensa-softmmu" >> - make -j$(expr $(nproc) + 1) all check-build >> >> +# Job to cross-build specific accelerators. >> +# >> +# Set the $ACCEL variable to select the specific accelerator (default to >> +# KVM), and set extra options (such disabling other accelerators) via the >> +# $ACCEL_CONFIGURE_OPTS variable. >> +.cross_accel_build_job: >> + stage: build >> + image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest >> + timeout: 30m >> + script: >> + - mkdir build >> + - cd build >> + - PKG_CONFIG_PATH=$PKG_CONFIG_PATH >> + ../configure --enable-werror $QEMU_CONFIGURE_OPTS --disable-tools >> + --enable-${ACCEL:-kvm} --target-list="$TARGETS" $ACCEL_CONFIGURE_OPTS >> + - make -j$(expr $(nproc) + 1) all check-build >> + >> .cross_user_build_job: >> stage: build >> image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest > > I wonder whether we could also simply use the .cross_user_build_job - e.g. > by adding a $EXTRA_CONFIGURE_OPTS variable in the "../configure ..." line so > that the accel-jobs could use that for their --enable... and --disable... > settings? Well cross_user_build_job build tools (I'm not sure that desired). > Anyway, I've got no strong opinion on that one, and I'm also fine if we add > this new template, so: > > Reviewed-by: Thomas Huth Thanks, we can improve on top.