From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgsan-0007EE-1J for qemu-devel@nongnu.org; Mon, 05 Sep 2016 08:01:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgsai-0002nN-T3 for qemu-devel@nongnu.org; Mon, 05 Sep 2016 08:01:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgsai-0002nI-O3 for qemu-devel@nongnu.org; Mon, 05 Sep 2016 08:01:32 -0400 References: <20160905111620.GA22359@work-vm> <1473075436-32489-1-git-send-email-ashijeetacharya@gmail.com> <122bc56c-0025-695a-8e2f-63aa03377879@redhat.com> From: Paolo Bonzini Message-ID: <39d8a740-7d86-6e5b-7afa-a9de516920e3@redhat.com> Date: Mon, 5 Sep 2016 14:01:27 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya Cc: lcapitulino@redhat.com, quintela@redhat.com, amit.shah@redhat.com, eblake@redhat.com, armbru@redhat.com, "dgilbert@redhat.com" , QEMU Developers On 05/09/2016 13:59, Ashijeet Acharya wrote: >>> >> + if (has_migrate_set_speed) { >>> >> + qmp_migrate_set_speed(migrate_set_speed, NULL); >>> >> + } >>> >> + if (has_migrate_set_downtime) { >>> >> + qmp_migrate_set_downtime(migrate_set_downtime, NULL); >>> >> + } >> > >> > This is backwards; qmp_migrate_set_speed and qmp_migrate_set_downtime >> > should be implemented in terms of qmp_migrate_set_parameters, not the >> > other way round. > > Okay. Got it! Thinking more about it, it's even better to have two patches. One doing it this way (qmp_migrate_set_parameters calls the old functions), the second that reverses the direction. Thanks! Paolo