From: Halil Pasic <pasic@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>,
Guenther Hutzl <hutzl@linux.vnet.ibm.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] remove unused VMSTateField.start
Date: Mon, 31 Oct 2016 18:33:15 +0100 [thread overview]
Message-ID: <39e2f665-307a-032c-bbd4-f52a46704ec7@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161020132556.67321-1-pasic@linux.vnet.ibm.com>
ping
I would like to do further work based on this, and Dave's review
for v1 was quite favorable (IMHO). Any chance of this getting
merged soon (or receiving critical comments so I can move forward)?
Cheers,
Halil
On 10/20/2016 03:25 PM, Halil Pasic wrote:
> The member VMStateField.start was solely used to implement the partial
> data migration for VBUFFER data (basically provide migration for a
> sub-buffer). However the implementation of this feature is broken, but
> this goes unnoticed since the feature is not used at all.
>
> Let us add an unit test for VBUFFER and then remove the useless
> VMStateFiled.start.
>
> An additional benefit is that .start can be re introduced to be used for
> linked structures as proposed by Jianjun in "[QEMU PATCH v6 2/2]
> migration: migrate QTAILQ".
>
> Guenther Hutzl (1):
> tests/test-vmstate.c: add vBuffer test
>
> Halil Pasic (1):
> migration: drop unused VMStateField.start
>
> hw/char/exynos4210_uart.c | 2 +-
> hw/display/g364fb.c | 2 +-
> hw/dma/pl330.c | 8 ++--
> hw/intc/exynos4210_gic.c | 2 +-
> hw/ipmi/isa_ipmi_bt.c | 4 +-
> hw/ipmi/isa_ipmi_kcs.c | 4 +-
> hw/net/vmxnet3.c | 2 +-
> hw/nvram/mac_nvram.c | 2 +-
> hw/nvram/spapr_nvram.c | 2 +-
> hw/sd/sdhci.c | 2 +-
> hw/timer/m48t59.c | 2 +-
> include/migration/vmstate.h | 20 +++-----
> migration/savevm.c | 2 +-
> migration/vmstate.c | 4 +-
> target-s390x/machine.c | 2 +-
> tests/test-vmstate.c | 114 ++++++++++++++++++++++++++++++++++++++++++++
> util/fifo8.c | 2 +-
> 17 files changed, 141 insertions(+), 35 deletions(-)
>
prev parent reply other threads:[~2016-10-31 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 13:25 [Qemu-devel] [PATCH v2 0/2] remove unused VMSTateField.start Halil Pasic
2016-10-20 13:25 ` [Qemu-devel] [PATCH v2 1/2] tests/test-vmstate.c: add vBuffer test Halil Pasic
2016-10-20 13:25 ` [Qemu-devel] [PATCH v2 2/2] migration: drop unused VMStateField.start Halil Pasic
2017-01-30 15:28 ` Halil Pasic
2017-01-31 20:00 ` Dr. David Alan Gilbert
2017-02-01 13:02 ` Halil Pasic
2017-02-01 18:41 ` Dr. David Alan Gilbert
2016-10-20 13:48 ` [Qemu-devel] [PATCH v2 0/2] remove unused VMSTateField.start no-reply
2016-10-31 17:33 ` Halil Pasic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e2f665-307a-032c-bbd4-f52a46704ec7@linux.vnet.ibm.com \
--to=pasic@linux.vnet.ibm.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=hutzl@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).