From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1GSd-00069g-9R for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:33:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1GSY-0001gN-D2 for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:33:27 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35751 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1GSY-0001gJ-6R for qemu-devel@nongnu.org; Mon, 31 Oct 2016 13:33:22 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9VHT1jY058107 for ; Mon, 31 Oct 2016 13:33:21 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 26e53kkv9c-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 31 Oct 2016 13:33:21 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 31 Oct 2016 17:33:19 -0000 From: Halil Pasic References: <20161020132556.67321-1-pasic@linux.vnet.ibm.com> Date: Mon, 31 Oct 2016 18:33:15 +0100 MIME-Version: 1.0 In-Reply-To: <20161020132556.67321-1-pasic@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: <39e2f665-307a-032c-bbd4-f52a46704ec7@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] remove unused VMSTateField.start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amit Shah , Guenther Hutzl , "Dr. David Alan Gilbert" , Juan Quintela ping I would like to do further work based on this, and Dave's review for v1 was quite favorable (IMHO). Any chance of this getting merged soon (or receiving critical comments so I can move forward)? Cheers, Halil On 10/20/2016 03:25 PM, Halil Pasic wrote: > The member VMStateField.start was solely used to implement the partial > data migration for VBUFFER data (basically provide migration for a > sub-buffer). However the implementation of this feature is broken, but > this goes unnoticed since the feature is not used at all. > > Let us add an unit test for VBUFFER and then remove the useless > VMStateFiled.start. > > An additional benefit is that .start can be re introduced to be used for > linked structures as proposed by Jianjun in "[QEMU PATCH v6 2/2] > migration: migrate QTAILQ". > > Guenther Hutzl (1): > tests/test-vmstate.c: add vBuffer test > > Halil Pasic (1): > migration: drop unused VMStateField.start > > hw/char/exynos4210_uart.c | 2 +- > hw/display/g364fb.c | 2 +- > hw/dma/pl330.c | 8 ++-- > hw/intc/exynos4210_gic.c | 2 +- > hw/ipmi/isa_ipmi_bt.c | 4 +- > hw/ipmi/isa_ipmi_kcs.c | 4 +- > hw/net/vmxnet3.c | 2 +- > hw/nvram/mac_nvram.c | 2 +- > hw/nvram/spapr_nvram.c | 2 +- > hw/sd/sdhci.c | 2 +- > hw/timer/m48t59.c | 2 +- > include/migration/vmstate.h | 20 +++----- > migration/savevm.c | 2 +- > migration/vmstate.c | 4 +- > target-s390x/machine.c | 2 +- > tests/test-vmstate.c | 114 ++++++++++++++++++++++++++++++++++++++++++++ > util/fifo8.c | 2 +- > 17 files changed, 141 insertions(+), 35 deletions(-) >