* [PATCH v3] target/loongarch: Fix qemu-system-loongarch64 assert failed with the option '-d int'
@ 2024-03-21 12:36 Song Gao
2024-03-21 14:11 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Song Gao @ 2024-03-21 12:36 UTC (permalink / raw)
To: qemu-devel; +Cc: richard.henderson, philmd, maobibo
qemu-system-loongarch64 assert failed with the option '-d int',
the helper_idle() raise an exception EXCP_HLT, but the exception name is undefined.
Signed-off-by: Song Gao <gaosong@loongson.cn>
---
target/loongarch/cpu.c | 74 +++++++++++++++++++++++-------------------
1 file changed, 40 insertions(+), 34 deletions(-)
diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c
index f6ffb3aadb..4d681a733e 100644
--- a/target/loongarch/cpu.c
+++ b/target/loongarch/cpu.c
@@ -45,33 +45,45 @@ const char * const fregnames[32] = {
"f24", "f25", "f26", "f27", "f28", "f29", "f30", "f31",
};
-static const char * const excp_names[] = {
- [EXCCODE_INT] = "Interrupt",
- [EXCCODE_PIL] = "Page invalid exception for load",
- [EXCCODE_PIS] = "Page invalid exception for store",
- [EXCCODE_PIF] = "Page invalid exception for fetch",
- [EXCCODE_PME] = "Page modified exception",
- [EXCCODE_PNR] = "Page Not Readable exception",
- [EXCCODE_PNX] = "Page Not Executable exception",
- [EXCCODE_PPI] = "Page Privilege error",
- [EXCCODE_ADEF] = "Address error for instruction fetch",
- [EXCCODE_ADEM] = "Address error for Memory access",
- [EXCCODE_SYS] = "Syscall",
- [EXCCODE_BRK] = "Break",
- [EXCCODE_INE] = "Instruction Non-Existent",
- [EXCCODE_IPE] = "Instruction privilege error",
- [EXCCODE_FPD] = "Floating Point Disabled",
- [EXCCODE_FPE] = "Floating Point Exception",
- [EXCCODE_DBP] = "Debug breakpoint",
- [EXCCODE_BCE] = "Bound Check Exception",
- [EXCCODE_SXD] = "128 bit vector instructions Disable exception",
- [EXCCODE_ASXD] = "256 bit vector instructions Disable exception",
+struct TypeExcp {
+ int32_t exccode;
+ const char *name;
+};
+
+static const struct TypeExcp excp_names[] = {
+ {EXCCODE_INT, "Interrupt"},
+ {EXCCODE_PIL, "Page invalid exception for load"},
+ {EXCCODE_PIS, "Page invalid exception for store"},
+ {EXCCODE_PIF, "Page invalid exception for fetch"},
+ {EXCCODE_PME, "Page modified exception"},
+ {EXCCODE_PNR, "Page Not Readable exception"},
+ {EXCCODE_PNX, "Page Not Executable exception"},
+ {EXCCODE_PPI, "Page Privilege error"},
+ {EXCCODE_ADEF, "Address error for instruction fetch"},
+ {EXCCODE_ADEM, "Address error for Memory access"},
+ {EXCCODE_SYS, "Syscall"},
+ {EXCCODE_BRK, "Break"},
+ {EXCCODE_INE, "Instruction Non-Existent"},
+ {EXCCODE_IPE, "Instruction privilege error"},
+ {EXCCODE_FPD, "Floating Point Disabled"},
+ {EXCCODE_FPE, "Floating Point Exception"},
+ {EXCCODE_DBP, "Debug breakpoint"},
+ {EXCCODE_BCE, "Bound Check Exception"},
+ {EXCCODE_SXD, "128 bit vector instructions Disable exception"},
+ {EXCCODE_ASXD, "256 bit vector instructions Disable exception"},
+ {EXCP_HLT, "EXCP_HLT"},
};
const char *loongarch_exception_name(int32_t exception)
{
- assert(excp_names[exception]);
- return excp_names[exception];
+ int i;
+
+ for (i = 0; i < ARRAY_SIZE(excp_names); i++) {
+ if (excp_names[i].exccode == exception) {
+ return excp_names[i].name;
+ }
+ }
+ return "Unknown";
}
void G_NORETURN do_raise_exception(CPULoongArchState *env,
@@ -80,7 +92,7 @@ void G_NORETURN do_raise_exception(CPULoongArchState *env,
{
CPUState *cs = env_cpu(env);
- qemu_log_mask(CPU_LOG_INT, "%s: %d (%s)\n",
+ qemu_log_mask(CPU_LOG_INT, "%s: expection: %d (%s)\n",
__func__,
exception,
loongarch_exception_name(exception));
@@ -154,22 +166,16 @@ static void loongarch_cpu_do_interrupt(CPUState *cs)
CPULoongArchState *env = cpu_env(cs);
bool update_badinstr = 1;
int cause = -1;
- const char *name;
bool tlbfill = FIELD_EX64(env->CSR_TLBRERA, CSR_TLBRERA, ISTLBR);
uint32_t vec_size = FIELD_EX64(env->CSR_ECFG, CSR_ECFG, VS);
if (cs->exception_index != EXCCODE_INT) {
- if (cs->exception_index < 0 ||
- cs->exception_index >= ARRAY_SIZE(excp_names)) {
- name = "unknown";
- } else {
- name = excp_names[cs->exception_index];
- }
-
qemu_log_mask(CPU_LOG_INT,
"%s enter: pc " TARGET_FMT_lx " ERA " TARGET_FMT_lx
- " TLBRERA " TARGET_FMT_lx " %s exception\n", __func__,
- env->pc, env->CSR_ERA, env->CSR_TLBRERA, name);
+ " TLBRERA " TARGET_FMT_lx " exception: %d (%s)\n",
+ __func__, env->pc, env->CSR_ERA, env->CSR_TLBRERA,
+ cs->exception_index,
+ loongarch_exception_name(cs->exception_index));
}
switch (cs->exception_index) {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] target/loongarch: Fix qemu-system-loongarch64 assert failed with the option '-d int'
2024-03-21 12:36 [PATCH v3] target/loongarch: Fix qemu-system-loongarch64 assert failed with the option '-d int' Song Gao
@ 2024-03-21 14:11 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-21 14:11 UTC (permalink / raw)
To: Song Gao, qemu-devel; +Cc: richard.henderson, maobibo
On 21/3/24 13:36, Song Gao wrote:
> qemu-system-loongarch64 assert failed with the option '-d int',
> the helper_idle() raise an exception EXCP_HLT, but the exception name is undefined.
>
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
> target/loongarch/cpu.c | 74 +++++++++++++++++++++++-------------------
> 1 file changed, 40 insertions(+), 34 deletions(-)
> -static const char * const excp_names[] = {
> - [EXCCODE_INT] = "Interrupt",
> - [EXCCODE_PIL] = "Page invalid exception for load",
> - [EXCCODE_PIS] = "Page invalid exception for store",
> - [EXCCODE_PIF] = "Page invalid exception for fetch",
> - [EXCCODE_PME] = "Page modified exception",
> - [EXCCODE_PNR] = "Page Not Readable exception",
> - [EXCCODE_PNX] = "Page Not Executable exception",
> - [EXCCODE_PPI] = "Page Privilege error",
> - [EXCCODE_ADEF] = "Address error for instruction fetch",
> - [EXCCODE_ADEM] = "Address error for Memory access",
> - [EXCCODE_SYS] = "Syscall",
> - [EXCCODE_BRK] = "Break",
> - [EXCCODE_INE] = "Instruction Non-Existent",
> - [EXCCODE_IPE] = "Instruction privilege error",
> - [EXCCODE_FPD] = "Floating Point Disabled",
> - [EXCCODE_FPE] = "Floating Point Exception",
> - [EXCCODE_DBP] = "Debug breakpoint",
> - [EXCCODE_BCE] = "Bound Check Exception",
> - [EXCCODE_SXD] = "128 bit vector instructions Disable exception",
> - [EXCCODE_ASXD] = "256 bit vector instructions Disable exception",
> +struct TypeExcp {
> + int32_t exccode;
> + const char *name;
const char * const name;
(Sorry I missed in review, no need to respin)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> +};
> +
> +static const struct TypeExcp excp_names[] = {
> + {EXCCODE_INT, "Interrupt"},
> + {EXCCODE_PIL, "Page invalid exception for load"},
> + {EXCCODE_PIS, "Page invalid exception for store"},
> + {EXCCODE_PIF, "Page invalid exception for fetch"},
> + {EXCCODE_PME, "Page modified exception"},
> + {EXCCODE_PNR, "Page Not Readable exception"},
> + {EXCCODE_PNX, "Page Not Executable exception"},
> + {EXCCODE_PPI, "Page Privilege error"},
> + {EXCCODE_ADEF, "Address error for instruction fetch"},
> + {EXCCODE_ADEM, "Address error for Memory access"},
> + {EXCCODE_SYS, "Syscall"},
> + {EXCCODE_BRK, "Break"},
> + {EXCCODE_INE, "Instruction Non-Existent"},
> + {EXCCODE_IPE, "Instruction privilege error"},
> + {EXCCODE_FPD, "Floating Point Disabled"},
> + {EXCCODE_FPE, "Floating Point Exception"},
> + {EXCCODE_DBP, "Debug breakpoint"},
> + {EXCCODE_BCE, "Bound Check Exception"},
> + {EXCCODE_SXD, "128 bit vector instructions Disable exception"},
> + {EXCCODE_ASXD, "256 bit vector instructions Disable exception"},
> + {EXCP_HLT, "EXCP_HLT"},
> };
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-21 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-21 12:36 [PATCH v3] target/loongarch: Fix qemu-system-loongarch64 assert failed with the option '-d int' Song Gao
2024-03-21 14:11 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).