From: Richard Henderson <richard.henderson@linaro.org>
To: Li Zhijian <lizhijian@cn.fujitsu.com>,
qemu-devel@nongnu.org, mst@redhat.com, peter.maydell@linaro.org
Cc: philip.li@intel.com, zhijianx.li@intel.com
Subject: Re: [Qemu-devel] [PATCH for-4.0 v3 3/4] i386: import bootparam.h
Date: Mon, 3 Dec 2018 10:44:52 -0600 [thread overview]
Message-ID: <39f2fb36-417f-a9fa-d462-39ce2c3af319@linaro.org> (raw)
In-Reply-To: <1543848532-12604-4-git-send-email-lizhijian@cn.fujitsu.com>
On 12/3/18 8:48 AM, Li Zhijian wrote:
> #include "hw/net/ne2000-isa.h"
> +#include <asm/bootparam.h>
>
> /* debug PC/ISA interrupts */
> //#define DEBUG_IRQ
> @@ -820,20 +821,6 @@ static long get_file_size(FILE *f)
> return size;
> }
>
> -/* setup_data types */
> -#define SETUP_NONE 0
> -#define SETUP_E820_EXT 1
> -#define SETUP_DTB 2
> -#define SETUP_PCI 3
> -#define SETUP_EFI 4
> -
> -struct setup_data {
> - uint64_t next;
> - uint32_t type;
> - uint32_t len;
> - uint8_t data[0];
> -} __attribute__((packed));
> -
No, this will fail to build for a non-x86 host, which will not have
<asm/bootparam.h>. Or, perhaps, have a *different* asm/bootparam.h that will
be specific to a different host cpu.
r~
next prev parent reply other threads:[~2018-12-03 16:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 14:48 [Qemu-devel] [PATCH for-4.0 v3 0/4] allow to load initrd below 4G for recent kernel Li Zhijian
2018-12-03 14:48 ` [Qemu-devel] [PATCH for-4.0 v3 1/4] unify len and addr type for memory/address APIs Li Zhijian
2018-12-03 14:42 ` Peter Maydell
2018-12-03 16:42 ` Richard Henderson
2018-12-04 17:40 ` Philippe Mathieu-Daudé
2018-12-06 2:09 ` Li Zhijian
2018-12-03 14:48 ` [Qemu-devel] [PATCH for-4.0 v3 2/4] refactor load_image_size Li Zhijian
2018-12-03 16:43 ` Richard Henderson
2018-12-03 14:48 ` [Qemu-devel] [PATCH for-4.0 v3 3/4] i386: import bootparam.h Li Zhijian
2018-12-03 16:44 ` Richard Henderson [this message]
2018-12-04 1:06 ` Michael S. Tsirkin
2018-12-04 8:09 ` Li Zhijian
2018-12-05 10:28 ` Li Zhijian
2018-12-05 15:33 ` Michael S. Tsirkin
2018-12-06 2:13 ` Li Zhijian
2018-12-03 14:48 ` [Qemu-devel] [PATCH for-4.0 v3 4/4] i386: allow to load initrd below 4G for recent linux Li Zhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39f2fb36-417f-a9fa-d462-39ce2c3af319@linaro.org \
--to=richard.henderson@linaro.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philip.li@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=zhijianx.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).