Re: [PATCH] hw/audio/es1370: Avoid four-letter word

[Thomas Huth <thuth@redhat.com>]

On 09/11/2023 19.01, Peter Maydell wrote:
> On Thu, 9 Nov 2023 at 17:36, Thomas Huth <thuth@redhat.com> wrote:
>>
>> Using certain four-letter words is not good style in source code,
>> so let's avoid that.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   hw/audio/es1370.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/hw/audio/es1370.c b/hw/audio/es1370.c
>> index 91c47330ad..bd460c810e 100644
>> --- a/hw/audio/es1370.c
>> +++ b/hw/audio/es1370.c
>> @@ -670,8 +670,7 @@ static void es1370_transfer_audio (ES1370State *s, struct chan *d, int loop_sel,
>>       cnt += (transferred + d->leftover) >> 2;
>>
>>       if (s->sctl & loop_sel) {
>> -        /* Bah, how stupid is that having a 0 represent true value?
>> -           i just spent few hours on this shit */
>> +        /* Bah, how stupid is that having a 0 represent true value? */
>>           AUD_log ("es1370: warning", "non looping mode\n");
>>       } else {
>>           d->frame_cnt = size;
>> --
>> 2.41.0
> 
> We could be more usefully clear here anyway:
> 
> /*
>   * loop_sel tells us which bit in the SCTL register to look at
>   * (either P1_LOOP_SEL, P2_LOOP_SEL or R1_LOOP_SEL). The sense
>   * of these bits is 0 for loop mode (set interrupt and keep recording
>   * when the sample count reaches zero) or 1 for stop mode (set
>   * interrupt and stop recording).
>   */

Since you already formulated that, could you please send it as a proper 
patch? I'll drop my trivial patch here then.

  Thomas