From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98701C54E58 for ; Tue, 12 Mar 2024 10:29:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjzMn-0007tb-5m; Tue, 12 Mar 2024 06:28:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjzMg-0007s0-LL; Tue, 12 Mar 2024 06:28:10 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjzMd-0005gA-MJ; Tue, 12 Mar 2024 06:28:10 -0400 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42C9sUVS014737; Tue, 12 Mar 2024 10:28:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=TytBLiVQBJefecAJDstfa5Wo6up7gUeAPTXj4Rz3Da8=; b=CLlOTteiM6cAUPMpIRQFqHLDnPjoL5i71ZkyjVVRIQYuQUWirWX2hCW9k10NY/yproBr KSp01NqTZG4cadx+Amf9OWMj3Ye4gJ9RmIPe29LQJA4SdeikKRq27T1hkKyO8LouZLso aRuaJDbiUq3AD1cA0bE3tOotXCgazgl6obHVYuI3jdH4l3+Cq1mCMZA7QPckvM7QjRRM 8RtkYugdItWz2ZCKiNxweJOU4apHLowLqPbEE3G76KqzxwzcxXaz0DpyeR3Ml6hAw6C1 +dasPoldWdtpZt1w7MPeKgNs7WdPtmDukIWvcUYmhQUoZxN2LgNrKtr81Rwtu4ANNwDF vA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wtmbu8r13-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2024 10:28:02 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 42CAR798010066; Tue, 12 Mar 2024 10:28:02 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wtmbu8r0n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2024 10:28:01 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42C9FaFk020423; Tue, 12 Mar 2024 10:28:00 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ws3kkx9kr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2024 10:28:00 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42CARwTN46596510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Mar 2024 10:28:00 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 15DCB5805A; Tue, 12 Mar 2024 10:27:58 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3AAD55806F; Tue, 12 Mar 2024 10:27:56 +0000 (GMT) Received: from [9.109.243.35] (unknown [9.109.243.35]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 12 Mar 2024 10:27:55 +0000 (GMT) Message-ID: <39ff316c-f28d-4986-95b6-ed2705d7cf8b@linux.ibm.com> Date: Tue, 12 Mar 2024 15:57:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/13] target/ppc: Prevent supervisor from modifying MSR[ME] Content-Language: en-US To: Nicholas Piggin , qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org, Daniel Henrique Barboza , David Gibson References: <20240311185200.2185753-1-npiggin@gmail.com> <20240311185200.2185753-10-npiggin@gmail.com> From: Harsh Prateek Bora In-Reply-To: <20240311185200.2185753-10-npiggin@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: hBHnS6caNYSmKdMN4XMrH5JUtOltmGj_ X-Proofpoint-GUID: D_evinNN4j3F_3QpgBOVwl9CQabVArug X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-12_08,2024-03-11_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 mlxlogscore=858 spamscore=0 suspectscore=0 clxscore=1015 phishscore=0 adultscore=0 mlxscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403120080 Received-SPF: pass client-ip=148.163.156.1; envelope-from=harshpb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/12/24 00:21, Nicholas Piggin wrote: > Prevent guest state modifying the MSR[ME] bit. Per ISA: > > An attempt to modify MSRME in privileged but non-hypervisor state is s/MSRME/MSR[ME] ? > ignored (i.e., the bit is not changed). > > Signed-off-by: Nicholas Piggin > --- > target/ppc/helper_regs.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c > index 410b39c231..25258986e3 100644 > --- a/target/ppc/helper_regs.c > +++ b/target/ppc/helper_regs.c > @@ -264,6 +264,11 @@ int hreg_store_msr(CPUPPCState *env, target_ulong value, int alter_hv) > value &= ~MSR_HVB; > value |= env->msr & MSR_HVB; > } > + /* Attempt to modify MSR[ME] in guest state is ignored */ > + if (is_book3s_arch2x(env) && !(env->msr & MSR_HVB)) { > + value &= ~(1 << MSR_ME); > + value |= env->msr & (1 << MSR_ME); > + } Reviewed-by: Harsh Prateek Bora > if ((value ^ env->msr) & (R_MSR_IR_MASK | R_MSR_DR_MASK)) { > cpu_interrupt_exittb(cs); > }