From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agZST-0006Tr-HL for qemu-devel@nongnu.org; Thu, 17 Mar 2016 11:03:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agZSS-00029U-4a for qemu-devel@nongnu.org; Thu, 17 Mar 2016 11:03:29 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 17 Mar 2016 16:03:22 +0100 From: michael@walle.cc In-Reply-To: <1456110933-5457-7-git-send-email-zxq_yx_007@163.com> References: <1456110933-5457-1-git-send-email-zxq_yx_007@163.com> <1456110933-5457-7-git-send-email-zxq_yx_007@163.com> Message-ID: <39ff92b233b0756e8fa631210d85c437@walle.cc> Subject: Re: [Qemu-devel] [PATCH v4 6/9] hw/timer: QOM'ify milkymist_sysctl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: xiaoqiang zhao Cc: peter.maydell@linaro.org, gxt@mprc.pku.edu.cn, i.mitsyanko@gmail.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, qemu-arm@nongnu.org, edgar.iglesias@gmail.com, m.kozlov@samsung.com, afaerber@suse.de [I had some problems with my mailserver and the v5 version didn't make it through. I know there is a v5 version of this patch series and I've tested with the v5 version] Am 2016-02-22 04:15, schrieb xiaoqiang zhao: > * split the old SysBus init function into an instance_init > and a Device realize function > * use DeviceClass::realize instead of SysBusDeviceClass::init > > Reviewed-by: Peter Maydell > Signed-off-by: xiaoqiang zhao Acked-by: Michael Walle Tested-by: Michael Walle -michael