From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MU6BJ-0003dP-Nu for qemu-devel@nongnu.org; Thu, 23 Jul 2009 17:50:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MU6BF-0003Vq-4v for qemu-devel@nongnu.org; Thu, 23 Jul 2009 17:50:29 -0400 Received: from [199.232.76.173] (port=43701 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MU6BE-0003VT-Ok for qemu-devel@nongnu.org; Thu, 23 Jul 2009 17:50:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36758 helo=mx2.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MU6BE-00015P-AA for qemu-devel@nongnu.org; Thu, 23 Jul 2009 17:50:24 -0400 Received: from relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 4FBE25FC9F for ; Thu, 23 Jul 2009 23:50:22 +0200 (CEST) Message-Id: <3B2224CA-005F-40BA-BAEB-1AA5860AE235@suse.de> From: Alexander Graf In-Reply-To: <1248384704-47824-4-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Re: [Qemu-devel] [PATCH 3/3] PPC: Round VGA BIOS size to page boundary Date: Thu, 23 Jul 2009 23:50:14 +0200 References: <1248384704-47824-1-git-send-email-agraf@suse.de> <1248384704-47824-2-git-send-email-agraf@suse.de> <1248384704-47824-3-git-send-email-agraf@suse.de> <1248384704-47824-4-git-send-email-agraf@suse.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel On 23.07.2009, at 23:31, Alexander Graf wrote: > When giving KVM a slot of a size not on page boundary, it chokes. So > let's > just round up the VGA BIOS size so nobody complains anymore and we > don't need > to implement sub-page slots. > > Required for booting a PPC guest in KVM. > > Signed-off-by: Alexander Graf > --- > hw/ppc_newworld.c | 3 +++ > hw/ppc_oldworld.c | 4 ++++ > 2 files changed, 7 insertions(+), 0 deletions(-) [...] > if (linux_boot) { > @@ -310,6 +313,7 @@ static void ppc_heathrow_init (ram_addr_t > ram_size, > pic = heathrow_pic_init(&pic_mem_index, 1, heathrow_irqs); > pci_bus = pci_grackle_init(0xfec00000, pic); > pci_vga_init(pci_bus, vga_bios_offset, vga_bios_size); > +printf("Mapping VGA to 0x%lx - 0x%lx\n", vga_bios_offset, > vga_bios_offset + vga_bios_size); Don't do this at home kids :-). Please skip the last chunk. Alex