From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNrHY-00021Z-K4 for qemu-devel@nongnu.org; Mon, 15 Oct 2012 16:29:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TNrHX-0002Z0-LP for qemu-devel@nongnu.org; Mon, 15 Oct 2012 16:29:00 -0400 Received: from mail.avalus.com ([89.16.176.221]:56622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNrHX-0002Yr-FF for qemu-devel@nongnu.org; Mon, 15 Oct 2012 16:28:59 -0400 Date: Mon, 15 Oct 2012 21:28:55 +0100 From: Alex Bligh Message-ID: <3C3D5F4A66E64EE2BCDB750F@nimrod.local> In-Reply-To: <507C63CB.7090006@redhat.com> References: <507C50E9.1050706@redhat.com> <507C51B6.1010803@redhat.com> <7C9D50488E80F46BDF7A16DA@Ximines.local> <507C63CB.7090006@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: Re: [Qemu-devel] [PATCH] qemu-img rebase: allow backing file to be specified as '-' Reply-To: Alex Bligh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Alex Bligh Eric, --On 15 October 2012 13:28:11 -0600 Eric Blake wrote: > Missing a Signed-off-by; as such, it cannot be taken as is. New patch sent under separate cover with Signed-Off-By: line. >> @@ -1580,7 +1581,7 @@ static int img_rebase(int argc, char **argv) >> if (!unsafe) { >> uint64_t num_sectors; >> uint64_t old_backing_num_sectors; >> - uint64_t new_backing_num_sectors; >> + uint64_t new_backing_num_sectors=0; > > As long as you are touching this line, fix the indentation to be > consistent (or is this unusual spacing an artifact of how you pasted > your commit after your '-- ' signature rather than submitting it via > 'git send-email' as a proper patch?). I'm totally confused by the spacing artifact. The new patch was generated with git-format-patch and git-send-email, and never touched a mailer (just in case), and also shows under the same circumstances. It doesn't show the bizarre indent in Mulberry, but does in Apple Mail. The patch applies cleanly with git-am and doesn't moan about whitespace, and as far as I can tell the resultant whitespace in the file is correct (i.e. matches the preceding and subsequent lines). > Also, most of qemu uses spaces on both sides of '='. Fixed. > But the overall idea looks nice. Thanks -- Alex Bligh