From: Bernhard Beschow <shentey@gmail.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: Roman Bolshakov <rbolshakov@ddn.com>,
Laurent Vivier <laurent@vivier.eu>,
Eduardo Habkost <eduardo@habkost.net>,
Cameron Esfahani <dirty@apple.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Zhao Liu <zhao1.liu@intel.com>,
Richard Henderson <richard.henderson@linaro.org>,
Fabiano Rosas <farosas@suse.de>,
qemu-trivial@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
qemu-block@nongnu.org, Phil Dennis-Jordan <phil@philjordan.eu>,
John Snow <jsnow@redhat.com>,
kvm@vger.kernel.org, Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH v2 09/11] hw/intc/apic: Ensure own APIC use in apic_register_{read, write}
Date: Fri, 17 Oct 2025 19:34:36 +0000 [thread overview]
Message-ID: <3C9DA9B8-8836-42F6-85CD-AB60327363EC@gmail.com> (raw)
In-Reply-To: <f074aed2-7702-4a4a-a7d5-7abeb29ea663@tls.msk.ru>
Am 17. Oktober 2025 14:58:50 UTC schrieb Michael Tokarev <mjt@tls.msk.ru>:
>17.10.2025 17:11, Bernhard Beschow wrote:
>> ... In apic_mem_{read,write}, the
>> own APIC instance is available as the opaque parameter
>
>> diff --git a/hw/intc/apic.c b/hw/intc/apic.c
>
>> @@ -876,7 +870,7 @@ static uint64_t apic_mem_read(void *opaque, hwaddr addr, unsigned size)
>> }
>> index = (addr >> 4) & 0xff;
>> - apic_register_read(index, &val);
>> + apic_register_read(opaque, index, &val);
>
>I think it would be better to use local variable here:
>
> APICCommonState *s = opaque;
>
>and use it down the line. Yes, there's just one usage, but it is
>still clearer this way (in my opinion anyway).
>
>Ditto in apic_mem_write.
I agree. Will fix in the next iteration.
Best regards,
Bernhard
>
>But it's more a nitpick really.
>
>Thanks,
>
>/mjt
next prev parent reply other threads:[~2025-10-17 19:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 14:11 [PATCH v2 00/11] Cleanup patches, mostly PC-related Bernhard Beschow
2025-10-17 14:11 ` [PATCH v2 01/11] hw/timer/i8254: Add I/O trace events Bernhard Beschow
2025-10-17 14:11 ` [PATCH v2 02/11] hw/audio/pcspk: " Bernhard Beschow
2025-10-17 14:11 ` [PATCH v2 03/11] hw/rtc/mc146818rtc: Convert CMOS_DPRINTF() into " Bernhard Beschow
2025-10-17 14:11 ` [PATCH v2 04/11] hw/rtc/mc146818rtc: Use ARRAY_SIZE macro Bernhard Beschow
2025-10-17 14:11 ` [PATCH v2 05/11] hw/rtc/mc146818rtc: Assert correct usage of mc146818rtc_set_cmos_data() Bernhard Beschow
2025-10-17 14:11 ` [PATCH v2 06/11] hw/ide/ide-internal: Move dma_buf_commit() into ide "namespace" Bernhard Beschow
2025-10-17 14:11 ` [PATCH v2 07/11] hw/i386/apic: Prefer APICCommonState over DeviceState Bernhard Beschow
2025-10-17 14:11 ` [PATCH v2 08/11] hw/i386/apic: Ensure own APIC use in apic_msr_{read, write} Bernhard Beschow
2025-10-17 14:11 ` [PATCH v2 09/11] hw/intc/apic: Ensure own APIC use in apic_register_{read, write} Bernhard Beschow
2025-10-17 14:58 ` Michael Tokarev
2025-10-17 19:34 ` Bernhard Beschow [this message]
2025-10-19 22:38 ` Bernhard Beschow
2025-10-17 14:11 ` [PATCH v2 10/11] hw/i386/x86-cpu: Remove now unused cpu_get_current_apic() Bernhard Beschow
2025-10-17 14:11 ` [PATCH v2 11/11] tests/qtest/ds1338-test: Reuse from_bcd() Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C9DA9B8-8836-42F6-85CD-AB60327363EC@gmail.com \
--to=shentey@gmail.com \
--cc=dirty@apple.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=laurent@vivier.eu \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phil@philjordan.eu \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=richard.henderson@linaro.org \
--cc=sunilmut@microsoft.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).