From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0070CCD199 for ; Fri, 17 Oct 2025 19:35:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v9qDv-0007OJ-DG; Fri, 17 Oct 2025 15:34:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v9qDt-0007Nc-CX for qemu-devel@nongnu.org; Fri, 17 Oct 2025 15:34:45 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v9qDq-0000qF-2i for qemu-devel@nongnu.org; Fri, 17 Oct 2025 15:34:45 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4711825a02bso10727345e9.2 for ; Fri, 17 Oct 2025 12:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760729680; x=1761334480; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=qMJV026dRbiXNw2a4Oxt82ibZLr50tUzegy5c9LVdz4=; b=Dkf3we1HqMa6sHU/Ha1mLOwjrws95Hb3r4NvfXMwppW3IHtjHaSeb5bxpzVyCZDYS7 X/JLibNAERNx5KZVHthTYXKf3XUcUIdrSq3BWQCerR9zuVMhoJCfRlrhrCbky1dtNiE4 +OIGz4atPZNhgp0Z9cN18rXHNThr3FPaJV+pFZi1vu3W/WUE1BJnWZBFuh+0ua1lVkn6 GbMJHgMMlDFUc8jSuatIEksGU0SdxMEZT7kTCk+F49P6XLr0BN72ZBAxKoOn9gIk+wYu IdCeVGmPy63LVZXhStEZurUdWlD4AikTXDF2c/BeRnabA+ii/sw9wVgt6q+eEIaSJptu vo5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760729680; x=1761334480; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qMJV026dRbiXNw2a4Oxt82ibZLr50tUzegy5c9LVdz4=; b=m/9jusYr9LjnuhfxdcsYF02BaPQ5tj6LmpeGg+PTMzr9/5Orj24bQ8hKwMz/iqRSmG KXuWyeq8DKqsGy7vvAuh+2T+KilWe5NXu+oRglVonlV6xsslJCjmX+n76ihFbPBiNS81 57lm+y57XGTaWlQaOHFW4rtVKevaJueGWDkoAaapuJoAo/0eJD/qK9izWGniSQvvmMh4 bst+72ZATF6zdnK0YO8RDQDV1GOGau3ZQ0ftxpe86VYCvvbI26U3RmRPmo0m6apFekAo XA0Fr0O2ezffHLzCFzz4Ub2yT4+zQc/huZN92wr9ZeyHmaf7r7ZTmmU3ZroR4Dc7XPH0 zVig== X-Forwarded-Encrypted: i=1; AJvYcCX/91vUuG07N0JGg6VSjI/7WB4bSqQJqoBKO/RT+kgwb6ETrX117JwkIwOBIedUU1d6gga3KkJipYLu@nongnu.org X-Gm-Message-State: AOJu0YwjIQ4Z1FasxNQuP9ELwxZyMcehx12RxEKVS/nX0Ceh11B023iK cNtmzOeKpqv7wJw1n2xpeH/Qx6Ix9JNYbqWInIPfn5paKz2veM2GAMFj X-Gm-Gg: ASbGncs0y3I3kSSqww1OaGj4VF1ZF4m7ZgKqlv3CZzMft6DalZqtwR4/tJw/xSkQiRQ XUZBMYajQ6NYGenwMZ1r/B39HGvNoZRD3vhM1FEUjRp7Hi3C0iWvJlipIepJw4uvHXIIVP/FWpx V6n3YNIEwX7f/kAIO60Kos5pMk5Qcuu39GgR0iN5i8TEI5CYqhPraQili5ngTHVbkarNhqHxMh2 LKOM6JJrmjKz1OtQTlbHBXBAUJnEs01bwtAEvHgynDdTxA/wWes8tohKasxap2Y41SrUfCQyHix 57RA+U0A3n/2gt3N+6C1bNsJSPHead3ZCStnkfSgARlOi9y1gh+uG5cCsmfb9gQ7DTpBQYW/TEv x8IFVh2QknBRq8Luf5lDjQQimXnAk2vVT5wN3MSD6pcZiCHQoSa/g8aoQRu+w49ZLmyElJERCf/ cXWwxPijiPJb2z0eCcMgXmhyB4ncjxKKIpvsILI1Pz7jVKZJu91DRl6gcavb0Z/Wg7WBiY+taxT eBTsVdlwYI= X-Google-Smtp-Source: AGHT+IHGjetnftVuysT/GTbROlmqCuOV4BZY3KYmTrCujddx2P4/UmIBc6Wo1oHWDywfaY714OaLRA== X-Received: by 2002:a05:6000:2887:b0:427:9a9:4604 with SMTP id ffacd0b85a97d-42709a9465fmr1647206f8f.45.1760729679739; Fri, 17 Oct 2025 12:34:39 -0700 (PDT) Received: from ehlo.thunderbird.net (p200300faaf271400485132244674f203.dip0.t-ipconnect.de. [2003:fa:af27:1400:4851:3224:4674:f203]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4711442d3ddsm95764585e9.5.2025.10.17.12.34.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Oct 2025 12:34:39 -0700 (PDT) Date: Fri, 17 Oct 2025 19:34:36 +0000 From: Bernhard Beschow To: Michael Tokarev , qemu-devel@nongnu.org CC: Roman Bolshakov , Laurent Vivier , Eduardo Habkost , Cameron Esfahani , "Michael S. Tsirkin" , Marcelo Tosatti , Marcel Apfelbaum , Paolo Bonzini , Sunil Muthuswamy , Zhao Liu , Richard Henderson , Fabiano Rosas , qemu-trivial@nongnu.org, Gerd Hoffmann , qemu-block@nongnu.org, Phil Dennis-Jordan , John Snow , kvm@vger.kernel.org, Laurent Vivier Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_09/11=5D_hw/intc/apic=3A_Ensure_?= =?US-ASCII?Q?own_APIC_use_in_apic=5Fregister=5F=7Bread=2C_write=7D?= In-Reply-To: References: <20251017141117.105944-1-shentey@gmail.com> <20251017141117.105944-10-shentey@gmail.com> Message-ID: <3C9DA9B8-8836-42F6-85CD-AB60327363EC@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=shentey@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 17=2E Oktober 2025 14:58:50 UTC schrieb Michael Tokarev : >17=2E10=2E2025 17:11, Bernhard Beschow wrote: >> =2E=2E=2E In apic_mem_{read,write}, the >> own APIC instance is available as the opaque parameter > >> diff --git a/hw/intc/apic=2Ec b/hw/intc/apic=2Ec > >> @@ -876,7 +870,7 @@ static uint64_t apic_mem_read(void *opaque, hwaddr = addr, unsigned size) >> } >> index =3D (addr >> 4) & 0xff; >> - apic_register_read(index, &val); >> + apic_register_read(opaque, index, &val); > >I think it would be better to use local variable here: > > APICCommonState *s =3D opaque; > >and use it down the line=2E Yes, there's just one usage, but it is >still clearer this way (in my opinion anyway)=2E > >Ditto in apic_mem_write=2E I agree=2E Will fix in the next iteration=2E Best regards, Bernhard > >But it's more a nitpick really=2E > >Thanks, > >/mjt