From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
qemu-block@nongnu.org, Amit Shah <amit@kernel.org>,
Jason Wang <jasowang@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tests: qpci_unplug_acpi_device_test() should not rely on global_qtest
Date: Wed, 8 May 2019 09:49:26 -0500 [thread overview]
Message-ID: <3a35117a-f92c-c508-cd5c-12942fd92174@redhat.com> (raw)
In-Reply-To: <20190508143209.24350-1-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On 5/8/19 9:32 AM, Thomas Huth wrote:
> libqos functions should not use functions that require global_qtest to
> be set, since such library functions could also be used by tests that
> deal with multiple test states. Add a parameter to this function to
> explicitly specify the test state.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/e1000e-test.c | 4 +++-
> tests/ivshmem-test.c | 9 ++++++---
> tests/libqos/pci-pc.c | 10 +++++-----
> tests/libqos/pci.h | 2 +-
> tests/virtio-blk-test.c | 3 ++-
> tests/virtio-net-test.c | 4 +++-
> tests/virtio-rng-test.c | 5 ++++-
> 7 files changed, 24 insertions(+), 13 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-08 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 14:32 [Qemu-devel] [PATCH] tests: qpci_unplug_acpi_device_test() should not rely on global_qtest Thomas Huth
2019-05-08 14:49 ` Eric Blake [this message]
2019-05-10 10:39 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a35117a-f92c-c508-cd5c-12942fd92174@redhat.com \
--to=eblake@redhat.com \
--cc=amit@kernel.org \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).