From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2F9C04A6B for ; Wed, 8 May 2019 14:51:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93C7220989 for ; Wed, 8 May 2019 14:51:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93C7220989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:38476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hONuP-0007Dq-Td for qemu-devel@archiver.kernel.org; Wed, 08 May 2019 10:51:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hONt0-0006SD-9z for qemu-devel@nongnu.org; Wed, 08 May 2019 10:49:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hONsz-00050c-BC for qemu-devel@nongnu.org; Wed, 08 May 2019 10:49:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40302) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hONsx-0004yO-4l; Wed, 08 May 2019 10:49:31 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 71A9D30024DD; Wed, 8 May 2019 14:49:30 +0000 (UTC) Received: from [10.3.116.15] (ovpn-116-15.phx2.redhat.com [10.3.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 568275DD9B; Wed, 8 May 2019 14:49:27 +0000 (UTC) To: Thomas Huth , qemu-devel@nongnu.org References: <20190508143209.24350-1-thuth@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <3a35117a-f92c-c508-cd5c-12942fd92174@redhat.com> Date: Wed, 8 May 2019 09:49:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190508143209.24350-1-thuth@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dlDHpP9Gkmc3pHrcOkvrCCMslsdvCHFRo" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 08 May 2019 14:49:30 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH] tests: qpci_unplug_acpi_device_test() should not rely on global_qtest X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , qemu-block@nongnu.org, Amit Shah , Jason Wang , Stefan Hajnoczi , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dlDHpP9Gkmc3pHrcOkvrCCMslsdvCHFRo From: Eric Blake To: Thomas Huth , qemu-devel@nongnu.org Cc: Laurent Vivier , qemu-block@nongnu.org, Amit Shah , Jason Wang , Stefan Hajnoczi , Paolo Bonzini Message-ID: <3a35117a-f92c-c508-cd5c-12942fd92174@redhat.com> Subject: Re: [Qemu-devel] [PATCH] tests: qpci_unplug_acpi_device_test() should not rely on global_qtest References: <20190508143209.24350-1-thuth@redhat.com> In-Reply-To: <20190508143209.24350-1-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 5/8/19 9:32 AM, Thomas Huth wrote: > libqos functions should not use functions that require global_qtest to > be set, since such library functions could also be used by tests that > deal with multiple test states. Add a parameter to this function to > explicitly specify the test state. >=20 > Signed-off-by: Thomas Huth > --- > tests/e1000e-test.c | 4 +++- > tests/ivshmem-test.c | 9 ++++++--- > tests/libqos/pci-pc.c | 10 +++++----- > tests/libqos/pci.h | 2 +- > tests/virtio-blk-test.c | 3 ++- > tests/virtio-net-test.c | 4 +++- > tests/virtio-rng-test.c | 5 ++++- > 7 files changed, 24 insertions(+), 13 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --dlDHpP9Gkmc3pHrcOkvrCCMslsdvCHFRo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlzS7HYACgkQp6FrSiUn Q2q7ggf9FPejLkzetSPSqisEsl1KlzQhbEic6UUdip+9xYvr2ADT+RIKNNt44yPN AHzqCYckb8ly1g7/IwSURLPi172nsentphhf7A1e5aZnBWXkoMD8pYhjzoaHDfnX AQLDVYVSWmm1CteX5dwV0+2UCYFf+4mircVKgPR8BhF1CU0Bo+QDKERM+Hupenmz wmyHMtTWfZe92sk5qnH6SMukJ8BQiF6PAZHWXwS4VbkovXU/E59/JrCFFZL1KoOD Kg9EtQ4p0XQVIKP6lTx6wmWxK4Akr0IAf39+mF4Ge3SpMF/2h1TCLfZt9zLgApIT CcqXW9uL0oRH6VQSH4Dtam9Rg092mw== =Lx1o -----END PGP SIGNATURE----- --dlDHpP9Gkmc3pHrcOkvrCCMslsdvCHFRo--