From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A0D7C2D0E4 for ; Thu, 12 Nov 2020 21:30:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64159216C4 for ; Thu, 12 Nov 2020 21:30:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nLxqqsxK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64159216C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdKAv-0001NR-Eo for qemu-devel@archiver.kernel.org; Thu, 12 Nov 2020 16:30:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdK8c-0007HW-NF for qemu-devel@nongnu.org; Thu, 12 Nov 2020 16:28:14 -0500 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:42947) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdK8a-0001Hh-75 for qemu-devel@nongnu.org; Thu, 12 Nov 2020 16:28:14 -0500 Received: by mail-pf1-x444.google.com with SMTP id x15so4411519pfm.9 for ; Thu, 12 Nov 2020 13:28:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uDqiIBkxGi66n/kIq1HVXowgI0TgnJBKvyyq+64Kc24=; b=nLxqqsxKb1IwzUf8ODTVQ/IPxc+2h3exQSpGZwwmHwPWf2CkSB/dYHILn5ym61BTrg 1hRXJ1Xr9E0XBX1T3jecoOWRaUgWfUoBl8i6XnikO0sepnxFgcGue6aE3uEmM/quN3/d fXWiQxJY1RuRbvNwAK2PGi/mTsDaEjld7fvhP6Jc1seZCrssh8WlDMWIlLlme/LRT7Qv vEhcccEbVWqbB0PS+m/54glMnSxsokIp3CET0yJIL8ImTVa4TXPHit1n18jkIDa7KUnt JE01Spe05Cbt9IEFv/gQGyqP7uK3wUL4A0aYKUzRdy++c3yuJtWLiLDc5mDVpgGO+OxE ONeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uDqiIBkxGi66n/kIq1HVXowgI0TgnJBKvyyq+64Kc24=; b=fTvGCtetp4/bYD1EAB1uwigk+ga/TV+gjFV46BhLki/zQN0nkLTV1g5eo8e4JSAlxs FmRkqHjD7rjodX7NCz3wzdr+7w1ML1upIfYJtd8NEJTUaCr4+C4XMuwRN2ppgs/zvMsT oZOAWoFlYLak/OtLczdUOqKBzx5aBWW34Vk/vwnVVfebaJ1wyPlGvGFvZyImStizIxjE LAi8gyWUJuRHXzMK3NCvnLqWxpgvsfetA8ABfjVvBJmCXFNG6YzauIoh7WqxBK5Q38Le Q9o8Ws/+5CoPpnAMkcIA1/4cnozWKCkEvYPhC/INfCSwzb/oIW3ZnPvYRgx8Cd5/9sdu D0VQ== X-Gm-Message-State: AOAM533XR8LD1N+ZGLLL6rWWIjO2W+9+DdGmWQDEQi7caGJp2JCn/b++ iO4K9aHmo46nPAz2AU+TNvRqOw== X-Google-Smtp-Source: ABdhPJxO6oVKJ38sC7JjlS5vBZHOzaZLZu1pxJjQQvIDR0qB2P7hw3c3pbbc4qR0CeSheC4vDjBX5A== X-Received: by 2002:a17:90a:e615:: with SMTP id j21mr1232066pjy.74.1605216489891; Thu, 12 Nov 2020 13:28:09 -0800 (PST) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id gk22sm7697867pjb.39.2020.11.12.13.28.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2020 13:28:08 -0800 (PST) Subject: Re: [PATCH v2 3/4] ppc/translate: Delay NaN checking after comparison To: LemonBoy , qemu-devel@nongnu.org References: <20201110105321.25889-1-thatlemon@gmail.com> <20201110105321.25889-4-thatlemon@gmail.com> From: Richard Henderson Message-ID: <3a56f92a-1415-7831-803b-25fca18b8691@linaro.org> Date: Thu, 12 Nov 2020 13:28:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201110105321.25889-4-thatlemon@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::444; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/10/20 2:53 AM, LemonBoy wrote: > Since we always perform a comparison between the two operands avoid > checking for NaN unless the result states they're unordered. > > Suggested-by: Richard Henderson > Signed-off-by: Giuseppe Musacchio > --- > target/ppc/fpu_helper.c | 82 +++++++++++++++++++++-------------------- > 1 file changed, 42 insertions(+), 40 deletions(-) Reviewed-by: Richard Henderson r~