qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: riku.voipio@linaro.org
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH 3/6] linux-user/signal.c: Don't pass sigaction uninitialised sa_flags
Date: Wed, 19 Feb 2014 12:35:26 +0200	[thread overview]
Message-ID: <3a5d30bf272c8db8e16e1e7ad5b8953f08df3e82.1392805802.git.riku.voipio@linaro.org> (raw)
In-Reply-To: <cover.1392805802.git.riku.voipio@linaro.org>

From: Peter Maydell <peter.maydell@linaro.org>

When forcing a fatal signal, we weren't initialising the sa_flags
field in the struct sigaction we used to reset the signal handler
to SIG_DFL.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 linux-user/signal.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/linux-user/signal.c b/linux-user/signal.c
index 82e8592..04638e2 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -420,6 +420,7 @@ static void QEMU_NORETURN force_sig(int target_sig)
      * it to arrive. */
     sigfillset(&act.sa_mask);
     act.sa_handler = SIG_DFL;
+    act.sa_flags = 0;
     sigaction(host_sig, &act, NULL);
 
     /* For some reason raise(host_sig) doesn't send the signal when
-- 
1.8.1.2

  parent reply	other threads:[~2014-02-19 10:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19 10:35 [Qemu-devel] [PULL 0/6] linux-user updates riku.voipio
2014-02-19 10:35 ` [Qemu-devel] [PATCH 1/6] linux-user: sync syscall numbers upto 3.13 riku.voipio
2014-02-19 10:35 ` [Qemu-devel] [PATCH 2/6] linux-user/elfload.c: Avoid calling g_free() on uninitialized data riku.voipio
2014-02-19 10:35 ` riku.voipio [this message]
2014-02-19 10:35 ` [Qemu-devel] [PATCH 4/6] linux-user: Fix error handling in lock_iovec() riku.voipio
2014-02-19 10:35 ` [Qemu-devel] [PATCH 5/6] linux-user: Implement BLKPG ioctl riku.voipio
2014-02-19 10:35 ` [Qemu-devel] [PATCH 6/6] linux-user: Fix error handling in target_to_host_semarray() riku.voipio
2014-02-21 14:32 ` [Qemu-devel] [PULL 0/6] linux-user updates Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a5d30bf272c8db8e16e1e7ad5b8953f08df3e82.1392805802.git.riku.voipio@linaro.org \
    --to=riku.voipio@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).