* [Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst parameter list
@ 2019-06-10 1:42 Richard Henderson
2019-06-11 13:06 ` David Hildenbrand
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2019-06-10 1:42 UTC (permalink / raw)
To: qemu-devel; +Cc: cohuck, david
The parameter list given in general register 1 shall be aligned
on a quadword boundary. This test currently succeeds or fails
depending on the compiler version used and the accidential layout
of the function's stack frame.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tests/tcg/s390x/csst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tcg/s390x/csst.c b/tests/tcg/s390x/csst.c
index 1dae9071fb..084d80af49 100644
--- a/tests/tcg/s390x/csst.c
+++ b/tests/tcg/s390x/csst.c
@@ -3,7 +3,7 @@
int main(void)
{
- uint64_t parmlist[] = {
+ uint64_t parmlist[] __attribute__((aligned(16))) = {
0xfedcba9876543210ull,
0,
0x7777777777777777ull,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst parameter list
2019-06-10 1:42 [Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst parameter list Richard Henderson
@ 2019-06-11 13:06 ` David Hildenbrand
2019-06-11 14:39 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: David Hildenbrand @ 2019-06-11 13:06 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: cohuck
On 10.06.19 03:42, Richard Henderson wrote:
> The parameter list given in general register 1 shall be aligned
> on a quadword boundary. This test currently succeeds or fails
> depending on the compiler version used and the accidential layout
> of the function's stack frame.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tests/tcg/s390x/csst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/s390x/csst.c b/tests/tcg/s390x/csst.c
> index 1dae9071fb..084d80af49 100644
> --- a/tests/tcg/s390x/csst.c
> +++ b/tests/tcg/s390x/csst.c
> @@ -3,7 +3,7 @@
>
> int main(void)
> {
> - uint64_t parmlist[] = {
> + uint64_t parmlist[] __attribute__((aligned(16))) = {
> 0xfedcba9876543210ull,
> 0,
> 0x7777777777777777ull,
>
Reviewed-by: David Hildenbrand <david@redhat.com>
Queuing it to
https://github.com/davidhildenbrand/qemu.git s390-tcg-next
for now. Let me know if you want to send this via a different PULL
request yourself.
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-11 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-10 1:42 [Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst parameter list Richard Henderson
2019-06-11 13:06 ` David Hildenbrand
2019-06-11 14:39 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).