From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5240EC742BD for ; Fri, 12 Jul 2019 13:58:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EBDA2080A for ; Fri, 12 Jul 2019 13:58:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EBDA2080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlw4b-0000j3-TJ for qemu-devel@archiver.kernel.org; Fri, 12 Jul 2019 09:58:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34057) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlw4P-0000Gn-4p for qemu-devel@nongnu.org; Fri, 12 Jul 2019 09:58:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlw4N-0006RL-S8 for qemu-devel@nongnu.org; Fri, 12 Jul 2019 09:58:41 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46426) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlw4K-0006MD-1p for qemu-devel@nongnu.org; Fri, 12 Jul 2019 09:58:37 -0400 Received: by mail-wr1-f66.google.com with SMTP id z1so10055171wru.13 for ; Fri, 12 Jul 2019 06:58:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mOUv4zwctbwa2rdmIdt3+9N9gVvFvK8LOhZkux+xB9E=; b=RoTogxSEofGOuLQ4RmwnMLQ+KgkCkFXIJ1WI9bqzVleF6mM8uetqmUNGNohu5U4Lgc oliihlRLUvNlBU39JBRjt7ty4aZUedsYyYpqiBykKQ4p/UOID7mR9FocOQhZ38/btEdy r42w8Doio8cB1C6cetJIvTRN+QAHXwZ1CUC00vvlsJWG1Kd6NuMHypDFiQXH+4/+8QS7 pX+EyHpPYG8oUAsLLA0/AhEQMtRIq4beYByNd2C41PT5XOu0dUaISW7BUkOBbkb/kkMP aICenrHcY+z0zy80oJ+CwmDZdep9ItKzFLemo4b+QXXaQUSgj3VO1Mm70M6TfxfDYYDb q2KA== X-Gm-Message-State: APjAAAVj7x21/85soiePv1518k6kK4kHNdkyEVs1HP4RtA+7eHxMsb7Y 2HFkb+n0F8sUCXoUNz0hnjurVQ== X-Google-Smtp-Source: APXvYqx+xYDMlWlOWXfsjy4wVkQNbMm5MaSPvt+A/5C4KYkxpt6b2ZKb1bKNNUdjGklLSEoYA9gvuQ== X-Received: by 2002:a05:6000:9:: with SMTP id h9mr12321963wrx.271.1562939911112; Fri, 12 Jul 2019 06:58:31 -0700 (PDT) Received: from [192.168.1.37] (62.red-83-42-61.dynamicip.rima-tde.net. [83.42.61.62]) by smtp.gmail.com with ESMTPSA id s25sm8087796wmc.21.2019.07.12.06.58.30 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jul 2019 06:58:30 -0700 (PDT) To: Aleksandar Markovic , qemu-devel@nongnu.org References: <1562931470-3700-1-git-send-email-aleksandar.markovic@rt-rk.com> <1562931470-3700-6-git-send-email-aleksandar.markovic@rt-rk.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <3a806b99-189a-97aa-fce6-d96af1f5ae5b@redhat.com> Date: Fri, 12 Jul 2019 15:58:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1562931470-3700-6-git-send-email-aleksandar.markovic@rt-rk.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.66 Subject: Re: [Qemu-devel] [PATCH for 4.1 4/4] target/mips: Add missing 'break' for certain cases of MTTR handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arikalo@wavecomp.com, sw@weilnetz.de, amarkovic@wavecomp.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/12/19 1:37 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > This was found by GCC 8.3 static analysis. > Similar to the previous one: Fixes: ead9360e2fb Reported-by: Stefan Weil > Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Thanks for cleaning this! Regards, Phil. > --- > target/mips/translate.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target/mips/translate.c b/target/mips/translate.c > index b1cf5f0..ca62800 100644 > --- a/target/mips/translate.c > +++ b/target/mips/translate.c > @@ -10055,6 +10055,7 @@ static void gen_mttr(CPUMIPSState *env, DisasContext *ctx, int rd, int rt, > gen_mtc0(ctx, t0, rd, sel); > break; > } > + break; > case 12: > switch (sel) { > case 0: > @@ -10064,6 +10065,7 @@ static void gen_mttr(CPUMIPSState *env, DisasContext *ctx, int rd, int rt, > gen_mtc0(ctx, t0, rd, sel); > break; > } > + break; > case 13: > switch (sel) { > case 0: >