From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Bernhard Beschow <shentey@gmail.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Peter Xu <peterx@redhat.com>, Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>
Subject: Re: [PATCH v2 5/5] hw/intc/apic: Pass CPU using QOM link property
Date: Fri, 6 Oct 2023 01:04:45 +0200 [thread overview]
Message-ID: <3a901d18-a07c-cc6c-f9ce-b500d07556cb@redhat.com> (raw)
In-Reply-To: <20231003082728.83496-6-philmd@linaro.org>
On 10/3/23 10:27, Philippe Mathieu-Daudé wrote:
> - /* TODO: convert to link<> */
> - apic = APIC_COMMON(cpu->apic_state);
> - apic->cpu = cpu;
> - apic->apicbase = APIC_DEFAULT_ADDRESS | MSR_IA32_APICBASE_ENABLE;
> + qdev_prop_set_uint32(cpu->apic_state, "base-addr",
> + APIC_DEFAULT_ADDRESS | MSR_IA32_APIC
For this to use a link, it's missing the corresponding
object_unref(apic->cpu) + apic->cpu = NULL assignment somewhere. For
example you can add it in apic_common_unrealize (called by
device_unparent - which is called in turn by x86_cpu_unrealizefn).
Paolo
next prev parent reply other threads:[~2023-10-05 23:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 8:27 [PATCH v2 0/5] hw/intc/apic: QOM cleanup Philippe Mathieu-Daudé
2023-10-03 8:27 ` [PATCH v2 1/5] hw/intc/apic: Use ERRP_GUARD() in apic_common_realize() Philippe Mathieu-Daudé
2023-10-03 20:50 ` Peter Xu
2023-10-03 8:27 ` [PATCH v2 2/5] hw/i386/apic: Defer error check from apic_get_class to kvm_apic_realize Philippe Mathieu-Daudé
2023-10-03 20:49 ` Peter Xu
2023-10-03 23:21 ` Bernhard Beschow
2023-10-05 7:06 ` Philippe Mathieu-Daudé
2023-10-05 7:40 ` Bernhard Beschow
2023-10-03 8:27 ` [PATCH v2 3/5] hw/i386/apic: Simplify apic_get_class() Philippe Mathieu-Daudé
2023-10-03 20:51 ` Peter Xu
2023-10-03 23:41 ` Bernhard Beschow
2023-10-03 8:27 ` [PATCH v2 4/5] hw/intc/apic: Rename x86_cpu_apic_create() -> x86_cpu_apic_new() Philippe Mathieu-Daudé
2023-10-03 20:51 ` Peter Xu
2023-10-05 23:00 ` Paolo Bonzini
2023-10-03 8:27 ` [PATCH v2 5/5] hw/intc/apic: Pass CPU using QOM link property Philippe Mathieu-Daudé
2023-10-05 23:04 ` Paolo Bonzini [this message]
2023-10-16 14:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a901d18-a07c-cc6c-f9ce-b500d07556cb@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=jasowang@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).