qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: David CARLIER <devnexen@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/9] Enabling BSD symbols
Date: Sat, 14 Nov 2020 09:47:48 +0100	[thread overview]
Message-ID: <3a964985-cfda-a5ba-5412-f3ff31515383@redhat.com> (raw)
In-Reply-To: <CA+XhMqxuYwkJLbCRZpAM7pM14CbLzx3BZ=n6FW14cg344xsFJA@mail.gmail.com>

On 29/06/2020 23.48, David CARLIER wrote:
> From 5c6022f21289eb6e78e93d584c766db82165dced Mon Sep 17 00:00:00 2001
> From: David Carlier <devnexen@gmail.com>
> Date: Mon, 29 Jun 2020 22:13:35 +0000
> Subject: [PATCH 1/9] Enabling BSD symbols.
> 
> Signed-off-by: David Carlier <devnexen@gmail.com>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 4a22dcd563..d81931ba5e 100755
> --- a/configure
> +++ b/configure
> @@ -903,8 +903,8 @@ SunOS)
>  ;;
>  Haiku)
>    haiku="yes"
> -  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS $QEMU_CFLAGS"
> -  LIBS="-lposix_error_mapper -lnetwork $LIBS"
> +  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -DBSD_SOURCE $QEMU_CFLAGS"

 Hi David!

In the version of Haiku that has recently been contributed as a VM for the
test/vm/ test suite, this is rather called _BSD_SOURCE, i.e. with an
underscore at the beginning. Has this been renamed in the course of time, or
was this a typo in your patch?

 Thomas



      parent reply	other threads:[~2020-11-14  8:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29 21:48 [PATCH 1/9] Enabling BSD symbols David CARLIER
2020-07-01 13:58 ` Eric Blake
2020-07-03 13:53 ` Peter Maydell
2020-11-14  8:47 ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a964985-cfda-a5ba-5412-f3ff31515383@redhat.com \
    --to=thuth@redhat.com \
    --cc=devnexen@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).