From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:41121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzMDS-0002uV-Vl for qemu-devel@nongnu.org; Thu, 28 Feb 2019 08:59:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzMDS-0004OW-3c for qemu-devel@nongnu.org; Thu, 28 Feb 2019 08:59:14 -0500 References: <4817f5c3b20aedba869608c06e76d11a722f4864.camel@gmail.com> From: Eric Blake Message-ID: <3aaecc9d-d03b-a754-0ef0-a65609777b2e@redhat.com> Date: Thu, 28 Feb 2019 07:59:02 -0600 MIME-Version: 1.0 In-Reply-To: <4817f5c3b20aedba869608c06e76d11a722f4864.camel@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] trivial malloc to g_malloc in thunk List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aarushi Mehta , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi , Julia Suvorova On 2/28/19 7:42 AM, Aarushi Mehta wrote: > Hi > > This is a trivial contribution part of the BiteSizedTasks on the wiki. > I found this discussion http://git.corpit.ru/?p=qemu.git;a=commit;h=b45c03f585ea9bb1af76c73e82195418c294919d > on migrating even g_malloc to g_new, is this not appropriate for the same? > The wiki can presumably use an update regarding this. > > Signed-off-by: Aarushi > --- > thunk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/thunk.c b/thunk.c > index d5d8645cd4..03fb2abab7 100644 > --- a/thunk.c > +++ b/thunk.c > @@ -89,7 +89,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types) > for(i = 0;i < 2; i++) { > offset = 0; > max_align = 1; > - se->field_offsets[i] = malloc(nb_fields * sizeof(int)); > + se->field_offsets[i] = g_malloc(nb_fields * sizeof(int)); Where is the counterpart free() that needs to be changed to g_free()? Also, you absolutely want g_new() or some other variant that separates the number of elements from the size of the element as two separate arguments, to avoid the possibility of integer overflow when using * in a single argument. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org