qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
	Yonggang Luo <luoyonggang@gmail.com>,
	qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"John Snow" <jsnow@redhat.com>
Subject: Re: [PATCH] .gitlab-ci.d/windows.yml: Disable the qtests in the MSYS2 job
Date: Fri, 16 Aug 2024 19:18:56 +0200	[thread overview]
Message-ID: <3abd50a8-6add-4406-ba21-ddd0c73965ed@linaro.org> (raw)
In-Reply-To: <ac16ccfe-65fa-4de4-95a1-7b2d2379c893@redhat.com>

On 16/8/24 18:40, Thomas Huth wrote:
> On 16/08/2024 18.34, Philippe Mathieu-Daudé wrote:
>> On 16/8/24 17:37, Thomas Huth wrote:
>>> The qtests are broken since a while in the MSYS2 job in the gitlab-CI,
>>> likely due to some changes in the MSYS2 environment. So far nobody has
>>> neither a clue what's going wrong here, nor an idea how to fix this
>>> (in fact most QEMU developers even don't have a Windows environment
>>> available for properly analyzing this problem), so let's disable the
>>> qtests here again to get at least the test coverage for the compilation
>>> and unit tests back to the CI.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>   .gitlab-ci.d/windows.yml | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
>>> index a83f23a786..9f3112f010 100644
>>> --- a/.gitlab-ci.d/windows.yml
>>> +++ b/.gitlab-ci.d/windows.yml
>>> @@ -23,6 +23,8 @@ msys2-64bit:
>>>       # for this job, because otherwise the build could not complete 
>>> within
>>>       # the project timeout.
>>>       CONFIGURE_ARGS:  --target-list=sparc-softmmu 
>>> --without-default-devices -Ddebug=false -Doptimization=0
>>> +    # The qtests are broken in the msys2 job on gitlab, so disable 
>>> them:
>>> +    TEST_ARGS: --no-suite qtest
>>
>> Then building system emulation is pointless, isn't it?
> 
> We're still running the unit tests and some others.

I tried to configure with '--disable-system' and the same tests
are run:

[1107/1109] Linking target tests/unit/test-vmstate.exe
[1108/1109] Linking target tests/unit/test-yank.exe
[1109/1109] Linking target tests/unit/test-qdev-global-props.exe
/c/Users/Administrator/qemu/build/pyvenv/bin/meson test  --no-rebuild -t 
1  --num-processes 1 --print-errorlogs  --suite unit
  1/93 qemu:unit / test-crypto-block                   OK 
0.22s   1 subtests passed
  2/93 qemu:unit / test-aio-multithread                OK 
6.94s   5 subtests passed
  3/93 qemu:unit / test-replication                    OK 
1.55s   8 subtests passed
  4/93 qemu:unit / test-bufferiszero                   OK 
9.70s   1 subtests passed
  5/93 qemu:unit / check-block-qdict                   OK 
0.09s   10 subtests passed
  6/93 qemu:unit / check-qdict                         OK 
0.06s   15 subtests passed
  7/93 qemu:unit / check-qnum                          OK 
0.08s   8 subtests passed
  8/93 qemu:unit / check-qstring                       OK 
0.08s   4 subtests passed
  9/93 qemu:unit / check-qlist                         OK 
0.06s   4 subtests passed
10/93 qemu:unit / check-qnull                         OK 
0.06s   2 subtests passed
11/93 qemu:unit / check-qobject                       OK 
0.08s   7 subtests passed
12/93 qemu:unit / check-qjson                         OK 
0.31s   31 subtests passed
13/93 qemu:unit / check-qlit                          OK 
0.09s   2 subtests passed
14/93 qemu:unit / test-error-report                   OK 
0.42s   6 subtests passed
15/93 qemu:unit / test-qobject-output-visitor         OK 
0.09s   16 subtests passed
16/93 qemu:unit / test-clone-visitor                  OK 
0.06s   7 subtests passed
17/93 qemu:unit / test-qobject-input-visitor          OK 
0.08s   42 subtests passed
18/93 qemu:unit / test-forward-visitor                OK 
0.08s   7 subtests passed
19/93 qemu:unit / test-string-input-visitor           OK 
0.11s   8 subtests passed
20/93 qemu:unit / test-string-output-visitor          OK 
0.08s   14 subtests passed
21/93 qemu:unit / test-visitor-serialization          OK 
0.08s   156 subtests passed
22/93 qemu:unit / test-bitmap                         OK 
0.08s   2 subtests passed
23/93 qemu:unit / test-resv-mem                       OK 
0.09s   3 subtests passed
24/93 qemu:unit / test-x86-topo                       OK 
0.06s   1 subtests passed
25/93 qemu:unit / test-cutils                         OK 
0.08s   179 subtests passed
26/93 qemu:unit / test-div128                         OK 
0.08s   2 subtests passed
27/93 qemu:unit / test-shift128                       OK 
0.06s   2 subtests passed
28/93 qemu:unit / test-mul64                          OK 
0.08s   2 subtests passed
29/93 qemu:unit / test-int128                         OK 
0.08s   11 subtests passed
30/93 qemu:unit / rcutorture                          OK 
2.34s   2 subtests passed
31/93 qemu:unit / test-rcu-list                       OK 
4.20s   3 subtests passed
32/93 qemu:unit / test-rcu-simpleq                    OK 
4.20s   3 subtests passed
33/93 qemu:unit / test-rcu-tailq                      OK 
4.20s   3 subtests passed
34/93 qemu:unit / test-rcu-slist                      OK 
4.20s   3 subtests passed
35/93 qemu:unit / test-qdist                          OK 
0.09s   8 subtests passed
36/93 qemu:unit / test-qht                            OK 
1.94s   2 subtests passed
37/93 qemu:unit / test-qtree                          OK 
0.09s   4 subtests passed
38/93 qemu:unit / test-bitops                         OK 
0.08s   6 subtests passed
39/93 qemu:unit / test-bitcnt                         OK 
0.06s   4 subtests passed
40/93 qemu:unit / test-qgraph                         OK 
0.06s   23 subtests passed
41/93 qemu:unit / check-qom-interface                 OK 
0.09s   2 subtests passed
42/93 qemu:unit / check-qom-proplist                  OK 
0.08s   9 subtests passed
43/93 qemu:unit / test-qemu-opts                      OK 
0.06s   19 subtests passed
44/93 qemu:unit / test-keyval                         OK 
0.08s   13 subtests passed
45/93 qemu:unit / test-logging                        OK 
0.17s   4 subtests passed
46/93 qemu:unit / test-qapi-util                      OK 
0.06s   2 subtests passed
47/93 qemu:unit / test-interval-tree                  OK 
0.08s   6 subtests passed
48/93 qemu:unit / test-qmp-event                      OK 
0.16s   6 subtests passed
49/93 qemu:unit / test-coroutine                      OK 
0.28s   12 subtests passed
50/93 qemu:unit / test-aio                            OK 
3.88s   27 subtests passed
51/93 qemu:unit / test-throttle                       OK 
0.33s   17 subtests passed
52/93 qemu:unit / test-thread-pool                    OK 
4.34s   6 subtests passed
53/93 qemu:unit / test-hbitmap                        OK 
0.55s   40 subtests passed
54/93 qemu:unit / test-bdrv-drain                     OK 
1.67s   30 subtests passed
55/93 qemu:unit / test-bdrv-graph-mod                 OK 
0.31s   5 subtests passed
56/93 qemu:unit / test-blockjob                       OK 
0.33s   8 subtests passed
57/93 qemu:unit / test-blockjob-txn                   OK 
0.42s   7 subtests passed
58/93 qemu:unit / test-block-backend                  OK 
0.31s   2 subtests passed
59/93 qemu:unit / test-block-iothread                 OK 
0.41s   22 subtests passed
60/93 qemu:unit / test-write-threshold                OK 
0.33s   2 subtests passed
61/93 qemu:unit / test-crypto-hash                    OK 
0.08s   5 subtests passed
62/93 qemu:unit / test-crypto-hmac                    OK 
0.08s   4 subtests passed
63/93 qemu:unit / test-crypto-cipher                  OK 
0.09s   17 subtests passed
64/93 qemu:unit / test-crypto-akcipher                OK 
0.09s   16 subtests passed
65/93 qemu:unit / test-crypto-secret                  OK 
0.11s   16 subtests passed
66/93 qemu:unit / test-crypto-der                     OK 
0.08s   4 subtests passed
67/93 qemu:unit / test-authz-simple                   OK 
0.08s   1 subtests passed
68/93 qemu:unit / test-authz-list                     OK 
0.08s   6 subtests passed
69/93 qemu:unit / test-authz-listfile                 OK 
0.16s   5 subtests passed
70/93 qemu:unit / test-io-task                        OK 
0.33s   5 subtests passed
71/93 qemu:unit / test-io-channel-socket              OK 
0.33s   8 subtests passed
72/93 qemu:unit / test-io-channel-file                OK 
0.20s   3 subtests passed
73/93 qemu:unit / test-io-channel-command             SKIP 
0.19s   0 subtests passed
74/93 qemu:unit / test-io-channel-buffer              OK 
0.17s   1 subtests passed
75/93 qemu:unit / test-io-channel-null                OK 
0.19s   1 subtests passed
76/93 qemu:unit / test-crypto-ivgen                   OK 
0.19s   9 subtests passed
77/93 qemu:unit / test-crypto-afsplit                 OK 
0.20s   4 subtests passed
78/93 qemu:unit / test-timed-average                  OK 
0.14s   1 subtests passed
79/93 qemu:unit / test-uuid                           OK 
0.08s   6 subtests passed
80/93 qemu:unit / ptimer-test                         OK 
0.09s   576 subtests passed
81/93 qemu:unit / test-iov                            OK 
0.08s   6 subtests passed
82/93 qemu:unit / test-opts-visitor                   OK 
0.14s   33 subtests passed
83/93 qemu:unit / test-xs-node                        OK 
0.08s   7 subtests passed
84/93 qemu:unit / test-virtio-dmabuf                  OK 
0.08s   5 subtests passed
85/93 qemu:unit / test-qmp-cmds                       OK 
0.16s   10 subtests passed
86/93 qemu:unit / test-xbzrle                         OK 
0.31s   6 subtests passed
87/93 qemu:unit / test-util-sockets                   OK 
0.16s   2 subtests passed
88/93 qemu:unit / test-base64                         OK 
0.08s   4 subtests passed
89/93 qemu:unit / test-smp-parse                      OK 
0.09s   10 subtests passed
90/93 qemu:unit / test-vmstate                        OK 
0.22s   23 subtests passed
91/93 qemu:unit / test-yank                           OK 
0.20s   6 subtests passed
92/93 qemu:unit / test-qdev-global-props              OK 
0.33s   4 subtests passed
93/93 qemu:unit / xml-preprocess                      OK               0.53s

Ok:                 92
Expected Fail:      0
Fail:               0
Unexpected Pass:    0
Skipped:            1
Timeout:            0

Full log written to C:/Users/Administrator/qemu/build/meson-logs/testlog.txt

Administrator@FOOBAR UCRT64 /c/Users/Administrator/qemu/build
#

>> Could we at least test the block tools? qemu-img seems to work:
>>
>> # ./qemu-img.exe --help
>> qemu-img version 9.0.92 (v9.1.0-rc2)
>> Copyright (c) 2003-2024 Fabrice Bellard and the QEMU Project developers
>> usage: qemu-img [standard options] command [command options]
>> QEMU disk image utility
>>
>>      '-h', '--help'       display this help and exit
>>      '-V', '--version'    output version information and exit
>> ...
>>
>> It doesn't work currently:
> ...
>> Administrator@FOOBAR UCRT64 /c/Users/Administrator/qemu/build
>> # make check-block
>> make: *** No rule to make target 'check-block'.  Stop.
> 
> check-block never worked on Windows as far as I know, it's disabled in 
> the meson.build there:
> 
> if not have_tools or host_os == 'windows'
>    subdir_done()
> endif

Ah OK, thanks.

> 
>   Thomas
> 



  reply	other threads:[~2024-08-16 17:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16 15:37 [PATCH] .gitlab-ci.d/windows.yml: Disable the qtests in the MSYS2 job Thomas Huth
2024-08-16 16:21 ` Alex Bennée
2024-08-16 16:33   ` Thomas Huth
2024-08-16 16:34 ` Philippe Mathieu-Daudé
2024-08-16 16:40   ` Thomas Huth
2024-08-16 17:18     ` Philippe Mathieu-Daudé [this message]
2024-08-16 17:25       ` Philippe Mathieu-Daudé
2024-08-19  5:30       ` Thomas Huth
2024-08-19 10:21         ` Philippe Mathieu-Daudé
2024-08-19 10:49           ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3abd50a8-6add-4406-ba21-ddd0c73965ed@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=jsnow@redhat.com \
    --cc=luoyonggang@gmail.com \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).