From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
qemu-devel@nongnu.org
Cc: Leonardo Bras <leobras@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH 1/5] migration: All this fields are unsigned
Date: Fri, 17 Dec 2021 12:25:50 -0800 [thread overview]
Message-ID: <3abdf9e0-3fa6-1bd6-0aa1-3325c0f23207@linaro.org> (raw)
In-Reply-To: <efafa479-0c54-fbf2-58f8-17462935daa9@redhat.com>
On 12/16/21 1:26 AM, Philippe Mathieu-Daudé wrote:
> On 12/16/21 10:13, Juan Quintela wrote:
>> multifd_send_terminate_threads(bool error) "error %d"
>
> Nitpicking: bool is unsigned :)
Eh, while the value is not negative, bool will promote to int in stdarg.
r~
next prev parent reply other threads:[~2021-12-17 20:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 9:13 [PATCH 0/5] migration: misc cleanups Juan Quintela
2021-12-16 9:13 ` [PATCH 1/5] migration: All this fields are unsigned Juan Quintela
2021-12-16 9:26 ` Philippe Mathieu-Daudé
2021-12-17 20:25 ` Richard Henderson [this message]
2021-12-17 21:01 ` Philippe Mathieu-Daudé
2021-12-16 9:13 ` [PATCH 2/5] migration: We only need last_stage in two places Juan Quintela
2021-12-16 9:30 ` Philippe Mathieu-Daudé
2021-12-20 19:02 ` Juan Quintela
2021-12-16 9:13 ` [PATCH 3/5] migration: ram_release_pages() always receive 1 page as argument Juan Quintela
2021-12-16 9:27 ` Philippe Mathieu-Daudé
2021-12-21 9:35 ` Juan Quintela
2021-12-16 9:13 ` [PATCH 4/5] migration: simplify do_compress_ram_page Juan Quintela
2021-12-16 9:13 ` [PATCH 5/5] migration: Move ram_release_pages() call to save_zero_page_to_file() Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3abdf9e0-3fa6-1bd6-0aa1-3325c0f23207@linaro.org \
--to=richard.henderson@linaro.org \
--cc=dgilbert@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).