Re: [Qemu-devel] [PATCH] iscsi: Avoid potential for get_status overflow

[Eric Blake <eblake@redhat.com>]

On 05/10/2018 08:28 AM, Paolo Bonzini wrote:
> On 08/05/2018 23:27, Eric Blake wrote:
>> Detected by Coverity: Multiplying two 32-bit int and assigning
>> the result to a 64-bit number is a risk of overflow.  Prior to
>> the conversion to byte-based interfaces, the block layer took
>> care of ensuring that a status request never exceeded 2G in
>> the driver; but after that conversion, the block layer expects
>> drivers to deal with any size request (the driver can always
>> truncate the request size back down, as long as it makes
>> progress).  So, in the off-chance that someone makes a large
>> request, we are at the mercy of whether iscsi_get_lba_status_task()
>> will cap things to at most INT_MAX / iscsilun->block_size when
>> it populates lbasd->num_blocks; since I could not easily audit
>> that, it's better to be safe than sorry by just forcing a 64-bit
>> multiply.
>>
>> Fixes: 92809c36
>> CC: qemu-stable@nongnu.org
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---

> 
> Queued, thanks.

It's been more than a month since this was queued but it is still not on 
mainline - did it get lost?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org