From: Steven Sistare <steven.sistare@oracle.com>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH V2] migration: file URI
Date: Thu, 22 Jun 2023 16:39:55 -0400 [thread overview]
Message-ID: <3adf97d5-c513-143b-d712-b818e4e4f17f@oracle.com> (raw)
In-Reply-To: <87h6qzk7rr.fsf@suse.de>
On 6/22/2023 8:20 AM, Fabiano Rosas wrote:
> Steve Sistare <steven.sistare@oracle.com> writes:
>
>> Extend the migration URI to support file:<filename>. This can be used for
>> any migration scenario that does not require a reverse path. It can be used
>> as an alternative to 'exec:cat > file' in minimized containers that do not
>> contain /bin/sh, and it is easier to use than the fd:<fdname> URI. It can
>> be used in HMP commands, and as a qemu command-line parameter.
>>
>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
>
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
>
> I'm ok with using this version over mine. I based my series on top of
> this and it works fine.
>
> I'm preparing a couple of patches with the test case. We'll need a fix
> to common migration code before it can work due to the latest
> migration-test.c changes.
Hi Fabiano,
I re-submitted my patch, along with an offset parameter requested by Daniel.
Perhaps you can add a test case using the offset?
- Steve
prev parent reply other threads:[~2023-06-22 20:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 18:38 [PATCH V2] migration: file URI Steve Sistare
2023-06-12 18:44 ` Peter Xu
2023-06-12 19:39 ` Steven Sistare
2023-06-12 19:55 ` Peter Xu
2023-06-14 15:47 ` Fabiano Rosas
2023-06-14 15:50 ` Peter Xu
2023-06-14 17:59 ` Fabiano Rosas
2023-06-14 18:38 ` Peter Xu
2023-06-15 14:50 ` Fabiano Rosas
2023-06-20 18:36 ` Steven Sistare
2023-06-20 19:35 ` Peter Xu
2023-06-21 12:40 ` Daniel P. Berrangé
2023-06-22 10:12 ` Daniel P. Berrangé
2023-06-22 12:28 ` Steven Sistare
2023-06-22 12:20 ` Fabiano Rosas
2023-06-22 20:39 ` Steven Sistare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3adf97d5-c513-143b-d712-b818e4e4f17f@oracle.com \
--to=steven.sistare@oracle.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).