From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Andrew Jones" <drjones@redhat.com>
Cc: Haibo Xu <haibo.xu@linaro.org>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH] target/arm/kvm: Check supported feature per accelerator (not per vCPU)
Date: Thu, 18 Jun 2020 12:59:27 +0200 [thread overview]
Message-ID: <3b0dd59d-40d1-745a-d083-cfdfc4a246c5@redhat.com> (raw)
In-Reply-To: <8729ee44-77dd-ab25-b400-859e59ced160@redhat.com>
On 18/06/20 12:17, Philippe Mathieu-Daudé wrote:
>>> cpu->kvm_init_features[0] |= 1 << KVM_ARM_VCPU_SVE;
>>> }
>>>
>>> --
>>> 2.21.3
>>>
>>>
>> At all callsites we pass current_accel() to the kvm_arm_<feat>_supported()
>> functions. Is there any reason not to drop their input parameter and just
>> use current_accel() internally?
> Clever idea :)
Or just the kvm_state global.
Paolo
prev parent reply other threads:[~2020-06-18 11:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 13:08 [PATCH] target/arm/kvm: Check supported feature per accelerator (not per vCPU) Philippe Mathieu-Daudé
2020-06-17 13:29 ` no-reply
2020-06-17 15:23 ` Andrew Jones
2020-06-17 17:37 ` Paolo Bonzini
2020-06-18 8:57 ` Andrew Jones
2020-06-18 10:59 ` Paolo Bonzini
2020-06-18 9:22 ` Andrew Jones
2020-06-18 10:17 ` Philippe Mathieu-Daudé
2020-06-18 10:59 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b0dd59d-40d1-745a-d083-cfdfc4a246c5@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=haibo.xu@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).