From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>,
Thomas Huth <thuth@redhat.com>,
Miroslav Rezanina <mrezanin@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH-for-5.2 1/5] hw/usb/hcd-xhci: Make xhci base model abstract
Date: Mon, 9 Nov 2020 14:40:52 +0100 [thread overview]
Message-ID: <3b24fd8a-c036-55b4-c741-28f31d1f82fa@redhat.com> (raw)
In-Reply-To: <20201109113046.fnv52ad22btvu4jr@sirius.home.kraxel.org>
On 11/9/20 12:30 PM, Gerd Hoffmann wrote:
>> static void test_xhci_hotplug(void)
>> {
>> - usb_test_hotplug(global_qtest, "xhci", "1", NULL);
>> + usb_test_hotplug(global_qtest, "nec-usb-xhci", "1", NULL);
>> }
>
> Better use qemu-xhci.
> I'm wondering how that worked before ...
Per commit b3937683147 ("tests: usb: Generic usb device hotplug")
this is the name of the bus, so "xhci" is correct, my patch isn't.
>
> take care,
> Gerd
>
next prev parent reply other threads:[~2020-11-09 13:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 11:13 [PATCH-for-5.2 0/5] hw/usb/hcd-xhci: Fix xhci-pci devices Philippe Mathieu-Daudé
2020-11-07 11:13 ` [PATCH-for-5.2 1/5] hw/usb/hcd-xhci: Make xhci base model abstract Philippe Mathieu-Daudé
2020-11-08 13:38 ` Sai Pavan Boddu
2020-11-09 9:51 ` Gerd Hoffmann
2020-11-09 11:00 ` Philippe Mathieu-Daudé
2020-11-09 11:30 ` Gerd Hoffmann
2020-11-09 13:40 ` Philippe Mathieu-Daudé [this message]
2020-11-07 11:13 ` [PATCH-for-5.2 2/5] hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI) Philippe Mathieu-Daudé
2020-11-08 13:40 ` Sai Pavan Boddu
2020-11-09 11:08 ` Gerd Hoffmann
2020-11-07 11:13 ` [PATCH-for-6.0 3/5] hw/usb/hcd-xhci: Rename "base-xhci" as TYPE_XHCI_COMMON Philippe Mathieu-Daudé
2020-11-07 11:13 ` [PATCH-for-6.0 4/5] hw/usb/hcd-xhci-pci: Use OBJECT_DECLARE_SIMPLE_TYPE() macro Philippe Mathieu-Daudé
2020-11-07 11:13 ` [PATCH-for-6.0 5/5] hw/usb/hcd-xhci-pci: Rename "pci-xhci" as TYPE_XHCI_PCI_COMMON Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b24fd8a-c036-55b4-c741-28f31d1f82fa@redhat.com \
--to=philmd@redhat.com \
--cc=kraxel@redhat.com \
--cc=mrezanin@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).