From: David Hildenbrand <david@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>,
qemu-devel@nongnu.org
Cc: thuth@redhat.com, cohuck@redhat.com, rth@twiddle.net
Subject: Re: [PATCH] target/s390x: fix execution with icount
Date: Mon, 2 Nov 2020 09:02:17 +0100 [thread overview]
Message-ID: <3b31e419-bef7-c858-9157-7e998f90ecb9@redhat.com> (raw)
In-Reply-To: <fd06fcf1-3850-3858-5e02-908d642d5229@linaro.org>
On 30.10.20 17:21, Richard Henderson wrote:
> On 10/30/20 1:36 AM, Pavel Dovgalyuk wrote:
>> This patch adds some gen_io_start() calls to allow execution
>> of s390x targets in icount mode with -smp 1.
>> It enables deterministic timers and record/replay features.
>
> Thanks for pointing this out.
>
> There are enough of these that I think it would be worthwhile to annotate them
> in insn-data.def instead, much as we do for privileged instructions with IF_PRIV.
>
> Perhaps call it IF_IO?
+1 good idea
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-11-02 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 8:36 [PATCH] target/s390x: fix execution with icount Pavel Dovgalyuk
2020-10-30 16:21 ` Richard Henderson
2020-11-02 8:02 ` David Hildenbrand [this message]
2020-11-02 9:25 ` Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b31e419-bef7-c858-9157-7e998f90ecb9@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).