From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88AB1C61DA4 for ; Tue, 7 Mar 2023 00:04:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZKoO-0005Y8-H5; Mon, 06 Mar 2023 19:04:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZKoJ-0005VH-A5 for qemu-devel@nongnu.org; Mon, 06 Mar 2023 19:04:07 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZKoF-0002VM-2A for qemu-devel@nongnu.org; Mon, 06 Mar 2023 19:04:05 -0500 Received: by mail-wr1-x436.google.com with SMTP id r18so10561612wrx.1 for ; Mon, 06 Mar 2023 16:04:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678147441; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aCoebHdkpPPcBj+jDj6eAqnOoTvKqv9yJqVJuh6zxc4=; b=ITBXTB+1zKGDHoZTVsRonOaDMrUqHqnX4pOMw9ymKVhGiNSw2/GrH8ti+weKugbOPT GKUwgBxCW+9oWIoSVyPlD/rpDgwxKsjcMW/uMYwlU6m4iyGgrDhean8IAwF9wfsq5Tce FLyth1JpiYYZRDN5REpA2UFRAmzzrjlEuwb8LmbX+7glbZi+h2dAUgwBkI2IyvoQXS2V Sp+Dh0VmprGn8ntnnu4WZMHGgwh3HVg8fg/sKNjKtgO8oCsjgZ81L9+DDs/E27d3Fyr/ OGpXgd7JlE+6t6fNiFDdG9ADZ0DZ5uQSZp4zU9rI7B7OmIZdYuS8YnN/W9UTH3b30oJd oUtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678147441; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aCoebHdkpPPcBj+jDj6eAqnOoTvKqv9yJqVJuh6zxc4=; b=5r5M26t5wUtWlY5h/DXelhkcInRqpjGBqbJKO75nfW/uoez9VBReR/YdqR1eefQ6uk gYDqu7l64KAbG98o65/jjIgCyg5A9GTRRImjwz8zAQQNoJ7Wcj8U/+P9p7JalGmUtIem 4l8XBx3O7EuFNVwTLBdYnEjqJZ+Vqwry7+trOG3oSjkJFWqyUkynB7IeUbMGsO2RwjJa w/+8r2ck+8C7pv7OqxoPZShYHk0+HZ6B14T5zz3v1hhz26IgKFxxwWn3dNehzAT4SHM4 ILLYCFppzUEM6PAmmEalJtIw2ti6tHY7NfB0znGINxPw3dv61S3liujjNzfzAocSNvtB +R6g== X-Gm-Message-State: AO0yUKWmXGonXDEoy5rYSnb0QkMO6n7/CDPMeQEFR9lO0kIyc1HY83UW bcQwYssLfqbIqzRzZzAeY9O2fQ== X-Google-Smtp-Source: AK7set925e8ERw46fmLpgWv+gEFzHiqLffUXsnCroE/8+/+bLFU+xSHjzFkCm++qCvTEIAVJarufxw== X-Received: by 2002:adf:ea90:0:b0:2c9:d90c:56c3 with SMTP id s16-20020adfea90000000b002c9d90c56c3mr7549062wrm.53.1678147441482; Mon, 06 Mar 2023 16:04:01 -0800 (PST) Received: from [192.168.1.115] (138.red-88-29-178.dynamicip.rima-tde.net. [88.29.178.138]) by smtp.gmail.com with ESMTPSA id m16-20020a056000009000b002be099f78c0sm11096122wrx.69.2023.03.06.16.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 16:04:01 -0800 (PST) Message-ID: <3b40fffe-c307-a0ea-7cea-c0f3b72848ec@linaro.org> Date: Tue, 7 Mar 2023 01:03:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 27/70] target/m68k: Avoid tcg_const_i32 in bfop_reg Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com References: <20230227054233.390271-1-richard.henderson@linaro.org> <20230227054233.390271-28-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230227054233.390271-28-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 27/2/23 06:41, Richard Henderson wrote: > Tidy up the whole function, hoisting is_bfffo as a common test > for whether tlen and tofs needed. Use tcg_constant_i32, and load > a separate temporary for mask. > > Signed-off-by: Richard Henderson > --- > target/m68k/translate.c | 42 ++++++++++++++++++++--------------------- > 1 file changed, 20 insertions(+), 22 deletions(-) > if (ext & 0x800) { > /* Variable offset */ > tcg_gen_andi_i32(tmp, DREG(ext, 6), 31); > tcg_gen_rotl_i32(QREG_CC_N, src, tmp); > tcg_gen_andc_i32(QREG_CC_N, QREG_CC_N, mask); > tcg_gen_rotr_i32(mask, mask, tmp); > - if (tofs) { > - tcg_gen_mov_i32(tofs, tmp); > + if (is_bfffo) { > + tofs = tmp; Reviewed-by: Philippe Mathieu-Daudé > } > } else {